Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Faraday v1 and v2 #21

Closed

Conversation

nipe0324
Copy link
Contributor

@nipe0324 nipe0324 commented Oct 15, 2023

Now, Faraday versions are 0.1x, 1.x and 2.x. I added faraday v1 and v2.

Faraday latest released

@@ -341,6 +341,10 @@ def stub_api_request
204
end

let(:response_hash) do
nil
end
Copy link
Contributor Author

@nipe0324 nipe0324 Oct 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Returns empty body response if 204 status code.

bblimke/webmock#190

And, Qiita PUT and DELETE APIs return a empty body.

JSON Schema(en): https://qiita.com/api/v2/schema?locale=en

@nipe0324
Copy link
Contributor Author

It happens below error when faraday v1 or v2.

`require': cannot load such file -- faraday_middleware (LoadError)

@nipe0324 nipe0324 closed this Oct 15, 2023
@nipe0324 nipe0324 deleted the support-faraday-v1-and-v2 branch October 15, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant