-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: exclude files and dirs #115
Conversation
Codecov Report
@@ Coverage Diff @@
## master #115 +/- ##
==========================================
+ Coverage 83.74% 87.93% +4.19%
==========================================
Files 8 8
Lines 406 431 +25
==========================================
+ Hits 340 379 +39
+ Misses 53 30 -23
- Partials 13 22 +9
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
hi @tk103331 |
reviser/dir.go
Outdated
@@ -73,6 +96,18 @@ func (d *SourceDir) walk(options ...SourceFileOption) fs.WalkDirFunc { | |||
} | |||
} | |||
|
|||
func (d *SourceDir) isExcluded(path string) bool { | |||
if d.hasExcludes { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
redundant param
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could be removed
reviser/dir.go
Outdated
dir: path, | ||
isRecursive: isRecursive, | ||
excludePatterns: patterns, | ||
hasExcludes: len(patterns) > 0, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
redundant param
feature: Add ‘excludes’ flag to support excluding files or directories.
fix #86