fix bug list-diff support dir mode
#140
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #140 +/- ##
==========================================
+ Coverage 90.38% 90.44% +0.05%
==========================================
Files 9 9
Lines 645 649 +4
==========================================
+ Hits 583 587 +4
Misses 43 43
Partials 19 19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Ericwww
force-pushed
the
fix-list-diff
branch
from
94f7d60
to
819921b
Compare
Ericwww
changed the title
list-diff support dir modelist-diff support dir mode
|
@incu6us Hello. If you are free, have a look on this pull request please, thank you. 😄 |
|
fixed in v3.6.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, everyone.
I want to integrate goimports-reviser into our CI/CD to ensure that code gating will fail when the import ordering is not as expected.
But I found that list-diff flag is not work when a recursive path (./...) is given.
I am making a PR to fix this bug. But I have one question.
From what I remember, when you run the goimports -l command, it only prints the file path without refactoring the code.
I don't know what behavior is expected here for goimports-reviser.
#139