Checksums #502
Checksums #502
Conversation
Conflicts: src/paxos/master.ml src/paxos/multi_paxos_fsm.ml src/paxos/value.ml src/system/startup.ml src/tlog/tlc2_test.ml src/tlog/tlogcollection_test.ml
doc/design/rolling-checksums.rst
Outdated
There was a problem hiding this comment.
I think we should mention here that usually it should not be possible for this to happen. Usually means: fsync set to true (which is the default) and none of the layers below (file system, hardware) lie about fsync behaviour.
src/node/catchup.ml
Outdated
There was a problem hiding this comment.
You can write this as tlog_coll # log_value_explicit i value ~validate false None >>= fun () ->
note the ~validate and >>= fun ()
src/node/store.ml
Outdated
There was a problem hiding this comment.
I know you're already changing this, but as a reminder to myself: set_checksum should happen in the same transaction as the one that bumps the i just above
|
Should we have some test for the upgrade scenario (as discussed earlier) ? |
buildInSandbox.sh
Outdated
There was a problem hiding this comment.
These shouldn't be required.
4 participants
No description provided.