chore: lint

incubateur-ademe · Dec 3, 2023 · 8a99259 · 8a99259
1 parent 32782d8
commit 8a99259
Show file tree

Hide file tree

Showing 19 changed files with 202 additions and 309 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -155,6 +155,10 @@ const config = {
         "plugin:@typescript-eslint/stylistic",
         "plugin:@typescript-eslint/recommended-type-checked",
       ],
+      parserOptions: {
+        project: "./tsconfig.json",
+        tsconfigRootDir: __dirname,
+      },
       plugins: [
         "@typescript-eslint",
         "typescript-sort-keys"

diff --git a/package.json b/package.json
@@ -53,6 +53,7 @@
     "eslint-config-next": "^14.0.3",
     "eslint-config-prettier": "^9.1.0",
     "eslint-plugin-jsx-a11y": "^6.7.1",
+    "eslint-plugin-lodash": "^7.4.0",
     "eslint-plugin-prettier": "^5.0.1",
     "eslint-plugin-simple-import-sort": "^10.0.0",
     "eslint-plugin-typescript-sort-keys": "^3.1.0",
@@ -62,4 +63,4 @@
     "tsconfig-paths": "^4.2.0",
     "typescript": "^5.3.2"
   }
-}
+}
diff --git a/src/components/DeclarationAccessibilite.tsx b/src/components/DeclarationAccessibilite.tsx
@@ -10,8 +10,7 @@ export const DeclarationAccessibilite = ({
     <div>
       <h1>Déclaration d’accessibilité</h1>
       <p>
-        <span>{produit}</span> s’engage à rendre son service accessible,
-        conformément à{" "}
+        <span>{produit}</span> s’engage à rendre son service accessible, conformément à{" "}
         <a href="https://www.legifrance.gouv.fr/loda/article_lc/LEGIARTI000037388867/">
           l’article 47 de la loi n° 2005-102 du 11 février 2005.
         </a>
@@ -35,10 +34,9 @@ export const DeclarationAccessibilite = ({
       </p>
       <h2>Amélioration et contact</h2>
       <p>
-        Si vous n’arrivez pas à accéder à un contenu ou à un service, vous
-        pouvez contacter le responsable de <span>{organisme}</span> pour être
-        orienté vers une alternative accessible ou obtenir le contenu sous une
-        autre forme.
+        Si vous n’arrivez pas à accéder à un contenu ou à un service, vous pouvez contacter le responsable de{" "}
+        <span>{organisme}</span> pour être orienté vers une alternative accessible ou obtenir le contenu sous une autre
+        forme.
       </p>
       <ul className="basic-information feedback h-card">
         <li>
@@ -47,18 +45,14 @@ export const DeclarationAccessibilite = ({
       </ul>
       <h2>Voie de recours</h2>
       <p>
-        Cette procédure est à utiliser dans le cas suivant : vous avez signalé
-        au responsable du site internet un défaut d’accessibilité qui vous
-        empêche d’accéder à un contenu ou à un des services du portail et vous
-        n’avez pas obtenu de réponse satisfaisante.
+        Cette procédure est à utiliser dans le cas suivant : vous avez signalé au responsable du site internet un défaut
+        d’accessibilité qui vous empêche d’accéder à un contenu ou à un des services du portail et vous n’avez pas
+        obtenu de réponse satisfaisante.
       </p>
       <p>Vous pouvez :</p>
       <ul>
         <li>
-          Écrire un message au{" "}
-          <a href="https://formulaire.defenseurdesdroits.fr/">
-            Défenseur des droits
-          </a>
+          Écrire un message au <a href="https://formulaire.defenseurdesdroits.fr/">Défenseur des droits</a>
         </li>
         <li>
           Contacter{" "}

diff --git a/src/components/MentionPart.tsx b/src/components/MentionPart.tsx
@@ -1,9 +1,9 @@
-export type MentionPartProps = {
-  title: string;
-  description: string;
+export interface MentionPartProps {
   children?: React.ReactNode | React.ReactNode[];
+  description: string;
   divProps?: React.HTMLAttributes<HTMLDivElement>;
-};
+  title: string;
+}
 
 export const MentionPart = (props: MentionPartProps): JSX.Element => {
   return (

diff --git a/src/components/StatTile.tsx b/src/components/StatTile.tsx
@@ -1,10 +1,10 @@
 import { fr } from "@codegouvfr/react-dsfr";
 
-export type StatTileProps = {
+export interface StatTileProps {
+  description?: React.ReactNode | string;
+  stats: number | string;
   title: string;
-  stats: string | number;
-  description?: string | React.ReactNode;
-};
+}
 
 export const StatTile = (props: StatTileProps): JSX.Element => {
   return (

diff --git a/src/lib/matomo.ts b/src/lib/matomo.ts
@@ -1,8 +1,8 @@
-export type MatomoResult = {
+export interface MatomoResult {
   nbPageViews: number;
   nbUniqPageViews: number;
   nbVisits: number;
-};
+}
 
 export const fetchMatomoData = async (): Promise<MatomoResult> => {
   const MATOMO_URL = [
@@ -14,7 +14,7 @@ export const fetchMatomoData = async (): Promise<MatomoResult> => {
       .then(data => data.json())
       .catch(() => {
         return null;
-      })
+      }),
   );
   const [nbVisitData, infoData] = await Promise.all(promises);
   return {

diff --git a/src/pages/404.tsx b/src/pages/404.tsx
@@ -1,6 +1,6 @@
-import type { NextPage } from "next";
-import { useEffect } from "react";
 import { push } from "@socialgouv/matomo-next";
+import { type NextPage } from "next";
+import { useEffect } from "react";
 
 const NotFound: NextPage = () => {
   useEffect(() => {

diff --git a/src/pages/_app.tsx b/src/pages/_app.tsx
@@ -1,18 +1,17 @@
-import { ReactNode, useEffect } from "react";
-import type { AppProps } from "next/app";
-import Head from "next/head";
-import Link from "next/link";
-import { useRouter } from "next/router";
-
-import { createEmotionSsrAdvancedApproach } from "tss-react/next";
-import { createNextDsfrIntegrationApi } from "@codegouvfr/react-dsfr/next-pagesdir";
-import { Footer } from "@codegouvfr/react-dsfr/Footer";
 import { fr } from "@codegouvfr/react-dsfr";
-import { Header } from "@codegouvfr/react-dsfr/Header";
 import { headerFooterDisplayItem } from "@codegouvfr/react-dsfr/Display";
-import { init } from "@socialgouv/matomo-next";
+import { Footer } from "@codegouvfr/react-dsfr/Footer";
+import { Header } from "@codegouvfr/react-dsfr/Header";
 import { MuiDsfrThemeProvider } from "@codegouvfr/react-dsfr/mui";
+import { createNextDsfrIntegrationApi } from "@codegouvfr/react-dsfr/next-pagesdir";
+import { init } from "@socialgouv/matomo-next";
+import { type AppProps } from "next/app";
+import Head from "next/head";
+import Link from "next/link";
+import { useRouter } from "next/router";
+import { type ReactNode, useEffect } from "react";
 import { useStyles } from "tss-react/dsfr";
+import { createEmotionSsrAdvancedApproach } from "tss-react/next";
 
 declare module "@codegouvfr/react-dsfr/next-pagesdir" {
   interface RegisterLink {
@@ -50,12 +49,11 @@ const { withDsfr, dsfrDocumentApi } = createNextDsfrIntegrationApi({
   ],
 });
 
-const { augmentDocumentWithEmotionCache, withAppEmotionCache } =
-  createEmotionSsrAdvancedApproach({
-    key: "css",
-  });
+const { augmentDocumentWithEmotionCache, withAppEmotionCache } = createEmotionSsrAdvancedApproach({
+  key: "css",
+});
 
-export { dsfrDocumentApi, augmentDocumentWithEmotionCache };
+export { augmentDocumentWithEmotionCache, dsfrDocumentApi };
 
 const brandTop = (
   <>
@@ -67,8 +65,7 @@ const brandTop = (
 
 const homeLinkPops = {
   href: "/",
-  title:
-    "Accueil - Nom de l’entité (ministère, secrétariat d‘état, gouvernement)",
+  title: "Accueil - Nom de l’entité (ministère, secrétariat d‘état, gouvernement)",
 };
 
 const bottomLinks = [
@@ -97,8 +94,8 @@ const bottomLinks = [
         process.env.NEXT_PUBLIC_APP_VERSION
           ? `/releases/tag/v${process.env.NEXT_PUBLIC_APP_VERSION}`
           : process.env.NEXT_PUBLIC_APP_VERSION_COMMIT
-          ? `/commit/${process.env.NEXT_PUBLIC_APP_VERSION}`
-          : ""
+            ? `/commit/${process.env.NEXT_PUBLIC_APP_VERSION}`
+            : ""
       }`,
     },
   },
@@ -113,17 +110,9 @@ const Layout = ({ children }: { children: ReactNode }) => {
     <MuiDsfrThemeProvider>
       <Head>
         <title>Template | Fabrique numérique des ministères sociaux</title>
-        {contentSecurityPolicy && (
-          <meta
-            httpEquiv="Content-Security-Policy"
-            content={contentSecurityPolicy}
-          ></meta>
-        )}
+        {contentSecurityPolicy && <meta httpEquiv="Content-Security-Policy" content={contentSecurityPolicy}></meta>}
         <link rel="icon" href="/favicon.ico" />
-        <meta
-          name="description"
-          content="Template de la fabrique des ministères sociaux."
-        />
+        <meta name="description" content="Template de la fabrique des ministères sociaux." />
       </Head>
       <Header
         brandTop={brandTop}

diff --git a/src/pages/_document.tsx b/src/pages/_document.tsx
@@ -1,8 +1,8 @@
-import { Html, Head, Main, NextScript, DocumentProps } from "next/document";
-import { dsfrDocumentApi, augmentDocumentWithEmotionCache } from "./_app";
+import { type DocumentProps, Head, Html, Main, NextScript } from "next/document";
 
-const { getColorSchemeHtmlAttributes, augmentDocumentForDsfr } =
-  dsfrDocumentApi;
+import { augmentDocumentWithEmotionCache, dsfrDocumentApi } from "./_app";
+
+const { getColorSchemeHtmlAttributes, augmentDocumentForDsfr } = dsfrDocumentApi;
 
 export default function Document(props: DocumentProps) {
   return (

diff --git a/src/pages/accessibilite.tsx b/src/pages/accessibilite.tsx
@@ -1,8 +1,7 @@
-import React from "react";
-import type { NextPage } from "next";
-import Head from "next/head";
-
 import { Alert } from "@codegouvfr/react-dsfr/Alert";
+import { type NextPage } from "next";
+import Head from "next/head";
+import React from "react";
 
 import { DeclarationAccessibilite } from "../components/DeclarationAccessibilite";
 
@@ -18,10 +17,7 @@ const Accessibilite: NextPage = () => {
           description={
             <>
               Utilisez le{" "}
-              <a href="https://betagouv.github.io/a11y-generateur-declaration/#create">
-                générateur de déclaration
-              </a>
-              .
+              <a href="https://betagouv.github.io/a11y-generateur-declaration/#create">générateur de déclaration</a>.
             </>
           }
           title={<>Cette page doit être mise à jour</>}

diff --git a/src/pages/cgu.tsx b/src/pages/cgu.tsx
@@ -1,8 +1,7 @@
-import React from "react";
-import type { NextPage } from "next";
-import Head from "next/head";
-
 import { Alert } from "@codegouvfr/react-dsfr/Alert";
+import { type NextPage } from "next";
+import Head from "next/head";
+import React from "react";
 
 import { MentionPart } from "../components/MentionPart";
 

diff --git a/src/pages/dsfr.tsx b/src/pages/dsfr.tsx
@@ -1,36 +1,23 @@
-import * as React from "react";
 import { fr } from "@codegouvfr/react-dsfr";
-
-import Head from "next/head";
-import { NextPage } from "next";
-
+import { Accordion } from "@codegouvfr/react-dsfr/Accordion";
 import { Alert } from "@codegouvfr/react-dsfr/Alert";
 import { Button } from "@codegouvfr/react-dsfr/Button";
-import { Tabs } from "@codegouvfr/react-dsfr/Tabs";
 import { Card } from "@codegouvfr/react-dsfr/Card";
-import { Accordion } from "@codegouvfr/react-dsfr/Accordion";
-
+import { Tabs } from "@codegouvfr/react-dsfr/Tabs";
 import Stack from "@mui/material/Stack";
+import { type NextPage } from "next";
+import Head from "next/head";
+import * as React from "react";
 
 const Home: NextPage = () => {
   return (
     <>
       <Head>
         <title>Template | Fabrique numérique des ministères sociaux</title>
       </Head>
-      <Alert
-        closable
-        description="Everything went well"
-        severity="success"
-        title="Message successfully sent"
-      />
+      <Alert closable description="Everything went well" severity="success" title="Message successfully sent" />
       <br />
-      <Alert
-        closable
-        description="Everything went bad"
-        severity="error"
-        title="Message NOT successfully sent"
-      />
+      <Alert closable description="Everything went bad" severity="error" title="Message NOT successfully sent" />
       <br />
       <Tabs
         tabs={[
@@ -55,12 +42,8 @@ const Home: NextPage = () => {
       />
       <br />
       <div className={fr.cx("fr-accordions-group")}>
-        <Accordion label="Name of the Accordion 1">
-          Content of the Accordion 1
-        </Accordion>
-        <Accordion label="Name of the Accordion 2">
-          Content of the Accordion 2
-        </Accordion>
+        <Accordion label="Name of the Accordion 1">Content of the Accordion 1</Accordion>
+        <Accordion label="Name of the Accordion 2">Content of the Accordion 2</Accordion>
       </div>
       <br />
       <Stack spacing={2} sx={{ mt: 5 }} direction="row">

diff --git a/src/pages/healthz.tsx b/src/pages/healthz.tsx
@@ -1,4 +1,4 @@
-import type { NextPage } from "next";
+import { type NextPage } from "next";
 import React from "react";
 
 const HealthZ: NextPage = () => {

diff --git a/src/pages/index.tsx b/src/pages/index.tsx
@@ -1,23 +1,18 @@
-import * as React from "react";
-import Head from "next/head";
-import { NextPage } from "next";
-import { push as matomoPush } from "@socialgouv/matomo-next";
 import { Alert } from "@codegouvfr/react-dsfr/Alert";
 import { Button } from "@codegouvfr/react-dsfr/Button";
 import Stack from "@mui/material/Stack";
+import { push as matomoPush } from "@socialgouv/matomo-next";
+import { type NextPage } from "next";
+import Head from "next/head";
+import * as React from "react";
 
 const Home: NextPage = () => {
   return (
     <>
       <Head>
         <title>Template | Fabrique numérique des ministères sociaux</title>
       </Head>
-      <Alert
-        closable
-        description="Everything went well"
-        severity="success"
-        title="Message successfully sent"
-      />
+      <Alert closable description="Everything went well" severity="success" title="Message successfully sent" />
       <div className="fr-grid-row fr-grid-row--center fr-grid-row--middle fr-mb-8w fr-mt-8w">
         <div className="fr-col-12 fr-col-md-6">
           <h1>
@@ -27,18 +22,15 @@ const Home: NextPage = () => {
             </span>
           </h1>
           <p className="fr-mt-10w">
-            Pariatur veniam ipsum pariatur elit ullamco sit quis ipsum ad veniam
-            proident sunt. Qui ut irure in quis reprehenderit. Laborum anim ad
-            laboris ipsum magna ullamco consequat ex consectetur. Duis sit
-            adipisicing ipsum occaecat commodo consequat officia ea. Cupidatat
-            fugiat reprehenderit aliqua eiusmod mollit Lorem consectetur. Minim
-            elit proident eu qui exercitation mollit id esse velit et dolore
-            velit laboris. Ipsum occaecat Lorem occaecat magna excepteur veniam
-            ullamco cupidatat irure incididunt velit nulla.
+            Pariatur veniam ipsum pariatur elit ullamco sit quis ipsum ad veniam proident sunt. Qui ut irure in quis
+            reprehenderit. Laborum anim ad laboris ipsum magna ullamco consequat ex consectetur. Duis sit adipisicing
+            ipsum occaecat commodo consequat officia ea. Cupidatat fugiat reprehenderit aliqua eiusmod mollit Lorem
+            consectetur. Minim elit proident eu qui exercitation mollit id esse velit et dolore velit laboris. Ipsum
+            occaecat Lorem occaecat magna excepteur veniam ullamco cupidatat irure incididunt velit nulla.
           </p>
         </div>
         <div className="fr-col-12 fr-col-offset-md-1 fr-col-md-4">
-          {/* eslint-disable-next-line jsx-a11y/img-redundant-alt*/}
+          {}
           {/* eslint-disable-next-line @next/next/no-img-element*/}
           <img
             className="fr-mt-2w"