Permettre d'appeler les routes de la carte autant en rendu HTML qu'en API #1112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
kolok
commented
Dec 9, 2024
Comment on lines
+156
to
+164
| def get_queryset(self): | ||
| # Manage the selection of sous_categorie_objet and actions | ||
| acteurs = self._acteurs_from_sous_categorie_objet_and_actions() | ||
| if self.digital == "1": | ||
| acteurs = acteurs.digital()[:100] | ||
| else: | ||
| bbox, acteurs = self._bbox_and_acteurs_from_location_or_epci(acteurs) | ||
| acteurs = acteurs[: self._get_max_displayed_acteurs()] | ||
| return acteurs |
There was a problem hiding this comment.
Reste à refactoriser get_queryset et get_context_data
kolok
changed the title
|
Cf discussion
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description succincte du problème résolu
Discuté entre Devs. Prmettre que les routes soit appelable par l'interface et en API.
La résolution métier reste la même
la différenciation entre les 2 route se fait lors du rendu
Reste à faire:
htmlet les renderjsonType de changement :
Auto-review
Les trucs à faire avant de demander une review :
.env.templateComment tester
En local / staging :