Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Derniers correctifs avant mise en prod : retours, cache, régressions #1270

Merged
merged 21 commits into from
Jan 28, 2025
Merged

Derniers correctifs avant mise en prod : retours, cache, régressions #1270

merged 21 commits into from
Jan 28, 2025

Conversation

fabienheureux
Copy link
Member

@fabienheureux fabienheureux commented Jan 27, 2025 •
edited
Loading

Description succincte du problème résolu

Quoi : correctifs pour préparer la mise en production du nouvel assistant

Pourquoi : Suite aux derniers tests de Delphine, pas mal de petites choses manquaient

  • régression suite à l'ajout de nginx
  • mauvais merge dans une PR de @kolok qui supprimait certains de mes changements et causaient des régressions
  • correctifs mal identifiés

Comment

  • ajout d'un middleware django qui définit les bons headers de cache et les passe à nginx
  • ajout d'un cookie logged_in qui permet de bypasser le cache nginx

@fabienheureux fabienheureux changed the title Assistant v2 fixes 27 1 Derniers correctifs avant mise en prod : retours, cache, régressions Jan 27, 2025
@fabienheureux fabienheureux force-pushed the assistant-v2-fixes-27-1 branch from f79ba38 to 67c4e11 Compare January 28, 2025 11:06
@fabienheureux fabienheureux force-pushed the assistant-v2-fixes-27-1 branch from 67c4e11 to e9b3bbc Compare January 28, 2025 11:06
@fabienheureux fabienheureux marked this pull request as ready for review January 28, 2025 11:25
@fabienheureux fabienheureux requested a review from a team as a code owner January 28, 2025 11:25
@fabienheureux fabienheureux requested review from kolok and maxcorbeau and removed request for a team January 28, 2025 11:25
@fabienheureux fabienheureux force-pushed the assistant-v2-fixes-27-1 branch 2 times, most recently from d719f45 to 2ac21f4 Compare January 28, 2025 11:47
@fabienheureux fabienheureux force-pushed the assistant-v2-fixes-27-1 branch from 2ac21f4 to c8e40a9 Compare January 28, 2025 11:53
kolok
kolok approved these changes Jan 28, 2025
View reviewed changes
docker-compose.yml Outdated Show resolved Hide resolved
docs/explications/🎨 Frontend.md Outdated Show resolved Hide resolved
docs/README.md Outdated Show resolved Hide resolved
@kolok
Copy link
Contributor

kolok commented Jan 28, 2025

Revue avec un peu de commentaire :)

@fabienheureux fabienheureux enabled auto-merge (squash) January 28, 2025 15:05
@fabienheureux fabienheureux merged commit 7c1d30e into main Jan 28, 2025
11 checks passed
@fabienheureux fabienheureux deleted the assistant-v2-fixes-27-1 branch January 28, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kolok kolok kolok approved these changes

@maxcorbeau maxcorbeau Awaiting requested review from maxcorbeau maxcorbeau is a code owner automatically assigned from incubateur-ademe/lvao-admin

Assignees

@fabienheureux fabienheureux

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fabienheureux @kolok