Follow-up: Cleanup tests after APP_HOME_INTERNAL_URL #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
fflorent
commented
May 14, 2024
fflorent
commented
- Simplifies some pieces of code
- Re-enable tests that were missing
- Cleanups
fflorent
force-pushed
the
cleanup-tests-after-app-home-internal-url
branch
from
a8390c9 to
19463ce
Compare
fflorent
force-pushed
the
introduce-app-home-internal-url
branch
from
ceefd82 to
e1569b8
Compare
fflorent
force-pushed
the
cleanup-tests-after-app-home-internal-url
branch
from
63dbd5d to
106b041
Compare
fflorent
force-pushed
the
introduce-app-home-internal-url
branch
from
e1569b8 to
de29a6a
Compare
fflorent
force-pushed
the
cleanup-tests-after-app-home-internal-url
branch
from
106b041 to
03a8c4d
Compare
This new API is somewhat patterned after the InstallAPI, but simpler whenever possible.
Patterned after TelemetryModel.ts
We will create a new enterprise toggle, so we will need to share the same CSS.
Since we've started using Markdown, why not a simple utility function to start using it?
Strongly patterned after SupportGristPage. In fact, it has almost the same structure. Perhaps one day it would be possible to synchronise the logic between the two toggles even further, but I couldn't see a simple way to do so now. For now, some code structure duplication seemed easiest in lieau of more abstractions.
Final ingredient. This surfaces the work in creating the backend config API, the frontend model, the grainjs observable, and the grainjs DOM and CSS components.
Currently translated at 99.7% (1364 of 1367 strings) Translation: Grist/client Translate-URL: https://hosted.weblate.org/projects/grist/client/fr/
Currently translated at 100.0% (1367 of 1367 strings) Translation: Grist/client Translate-URL: https://hosted.weblate.org/projects/grist/client/es/
Currently translated at 99.8% (1365 of 1367 strings) Translation: Grist/client Translate-URL: https://hosted.weblate.org/projects/grist/client/eu/
Co-authored-by: Paul's Grist Bot <paul+bot@getgrist.com>
Currently translated at 100.0% (1367 of 1367 strings) Translation: Grist/client Translate-URL: https://hosted.weblate.org/projects/grist/client/sk/
Currently translated at 99.8% (1365 of 1367 strings) Translation: Grist/client Translate-URL: https://hosted.weblate.org/projects/grist/client/eu/
Issues and PRs descriptions sometimes lacks of details we would like to have to better understand the motivations behind. I propose here templates to guide the reporters towards good descriptions. These templates are heavily inspired from the ones of the PeerTube project. Fixes gristlabs#1125 --------- Co-authored-by: CamilleLegeron <camille@telescoop.fr>
Currently translated at 99.7% (1374 of 1378 strings) Translation: Grist/client Translate-URL: https://hosted.weblate.org/projects/grist/client/es/
Currently translated at 100.0% (1378 of 1378 strings) Translation: Grist/client Translate-URL: https://hosted.weblate.org/projects/grist/client/es/
Currently translated at 100.0% (1378 of 1378 strings) Translation: Grist/client Translate-URL: https://hosted.weblate.org/projects/grist/client/sl/
Currently translated at 100.0% (1378 of 1378 strings) Translation: Grist/client Translate-URL: https://hosted.weblate.org/projects/grist/client/pt_BR/
Currently translated at 100.0% (1378 of 1378 strings) Translation: Grist/client Translate-URL: https://hosted.weblate.org/projects/grist/client/de/
Currently translated at 99.8% (1376 of 1378 strings) Translation: Grist/client Translate-URL: https://hosted.weblate.org/projects/grist/client/eu/
Test Plan: N/A Reviewers: jarek Reviewed By: jarek Differential Revision: https://phab.getgrist.com/D4308
We had `getgrist.com` hardcoded here, which only works for SaaS. The base domain as well as the way that orgs are encoded in the URL can be different in other circumstances. If we are encoding orgs in the domain name, that's easy. We just do `orgname.base.domain.name`. If we are not, then we first try a base domain, and if that isn't set, we'll use the domain of the home server.
For gristlabs#1140, I considered trying to use the existing fields in a better way, but because we already use the activations table to store preferences, we need to keep all of the existing data and its usage as-is. The enterprise code will use this new column to decide how long the trial period should be.
Currently translated at 95.2% (1394 of 1463 strings) Translation: Grist/client Translate-URL: https://hosted.weblate.org/projects/grist/client/es/
Currently translated at 95.7% (1401 of 1463 strings) Translation: Grist/client Translate-URL: https://hosted.weblate.org/projects/grist/client/es/
Currently translated at 95.7% (1401 of 1463 strings) Translation: Grist/client Translate-URL: https://hosted.weblate.org/projects/grist/client/es/
Currently translated at 96.9% (1418 of 1463 strings) Translation: Grist/client Translate-URL: https://hosted.weblate.org/projects/grist/client/es/
Currently translated at 96.9% (1418 of 1463 strings) Translation: Grist/client Translate-URL: https://hosted.weblate.org/projects/grist/client/es/
Currently translated at 98.8% (1446 of 1463 strings) Translation: Grist/client Translate-URL: https://hosted.weblate.org/projects/grist/client/es/
Currently translated at 98.8% (1446 of 1463 strings) Translation: Grist/client Translate-URL: https://hosted.weblate.org/projects/grist/client/es/
Currently translated at 99.8% (1461 of 1463 strings) Translation: Grist/client Translate-URL: https://hosted.weblate.org/projects/grist/client/es/
Currently translated at 99.8% (1461 of 1463 strings) Translation: Grist/client Translate-URL: https://hosted.weblate.org/projects/grist/client/es/
Currently translated at 100.0% (1463 of 1463 strings) Translation: Grist/client Translate-URL: https://hosted.weblate.org/projects/grist/client/es/
Currently translated at 100.0% (1463 of 1463 strings) Translation: Grist/client Translate-URL: https://hosted.weblate.org/projects/grist/client/es/
… easier. Summary: Refactor that should not change behavior, except that some less helpful log.debug messages are removed. Test Plan: This is a refactor that should not change behavior; existing tests should pass. Reviewers: jarek Reviewed By: jarek Differential Revision: https://phab.getgrist.com/D4399
Summary: Suggestions in ACE editor were trimmed for long column names with long examples. Test Plan: Added test case. Reviewers: georgegevoian Reviewed By: georgegevoian Differential Revision: https://phab.getgrist.com/D4401
Currently translated at 100.0% (1463 of 1463 strings) Translation: Grist/client Translate-URL: https://hosted.weblate.org/projects/grist/client/sl/
* Bump Chrome for Testing to 131 * Fix failing ReferenceColumns test
fflorent
force-pushed
the
cleanup-tests-after-app-home-internal-url
branch
from
7de1e98 to
d9598b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.