Skip to content

Commit

Permalink
Merge pull request #2 from nandinimd228/save-search-api-change
Browse files Browse the repository at this point in the history
Updated: SaveSearch API to work with 8.6
  • Loading branch information
utsav00 authored Apr 11, 2023
2 parents 1ef96c5 + a370043 commit 39e60e0
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 5 deletions.
5 changes: 4 additions & 1 deletion kibana.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
{
"id": "excelExport",
"version": "1.0.0",
"owner": {
"name": "excelExport"
},
"version": "8.6.2",
"kibanaVersion": "kibana",
"server": false,
"ui": true,
Expand Down
8 changes: 4 additions & 4 deletions public/panel_action/get_excel_panel_action.ts
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,8 @@ export class GetExcelPanelAction implements ActionDefinition<ActionContext> {
const { getSharingData } = await loadSharingDataHelpers();
return await getSharingData(
savedSearch.searchSource,
savedSearch, // TODO: get unsaved state (using embeddale.searchScope): https://github.com/elastic/kibana/issues/43977
this.core.uiSettings
savedSearch, // TODO: get unsaved state (using embeddable.searchScope): https://github.com/elastic/kibana/issues/43977
embeddable.services
);
}

Expand All @@ -67,13 +67,13 @@ export class GetExcelPanelAction implements ActionDefinition<ActionContext> {
}

const savedSearch = embeddable.getSavedSearch();
const { columns, searchSource } = await this.getSearchSource(savedSearch, embeddable);
const { columns, getSearchSource } = await this.getSearchSource(savedSearch, embeddable);

const kibanaTimezone = this.core.uiSettings.get('dateFormat:tz');
const browserTimezone = kibanaTimezone === 'Browser' ? moment.tz.guess() : kibanaTimezone;

const immediateJobParams: JobParamsDownloadCSV = {
searchSource,
searchSource: getSearchSource(),
columns,
browserTimezone,
title: savedSearch.title,
Expand Down

0 comments on commit 39e60e0

Please sign in to comment.