Add support for topologySpreadConstraints #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| version: 0.7.1 | ||
| appVersion: "0.7.1" | ||
| version: 0.7.2 | ||
| appVersion: "0.7.2" |
There was a problem hiding this comment.
This doesn't change the app version, just the chart version.
There was a problem hiding this comment.
I was not sure whether I should keep the appVersion unchanged.
I checked a couple of pervious commits, it looks like the appVersion is usually set to the same version with chart version.
There was a problem hiding this comment.
When the app version does change, the chart is going to be updated in order to pull in the new app version. There's no requirement for them to stay in sync, but @cnmcavoy may have some rules about it.
deploy/charts/harbor-container-webhook/templates/deployment.yaml
Outdated
Show resolved
Hide resolved
chunyanlv
force-pushed
the
chunyan-add-topologySpreadConstraints
branch
from
b410657 to
e206153
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.