Skip to content

cache icons #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

cache icons #4

wants to merge 1 commit into from

Conversation

tvdr
Copy link

@tvdr tvdr commented Jul 23, 2021

Hey, first of all, it's a great component.

While debugging ,i've noticed, that every sorting fires a network request - which some would consider as suboptimal :)

This PR offers one way to tackle this, fetching the svg once on init and inserting it hidden into the dom.

@indgy
Copy link
Owner

indgy commented Jul 28, 2021

Thanks for pointing this out, it's definitely not ideal to be issuing spurious network requests.

I had thought that by using an SVG sprite for the icons that the sprite would be loaded once then each icon would be fetched from the already loaded sprite. I'll check why this is not the case first as I'd rather avoid adding more code if possible, the svg sprite should be cached by the browser so using native functionality is a cheap easy win.

I'll reply when I've tested it more, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants