Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use mouse click to add a new time slot #494

Closed
wants to merge 0 commits into from
Closed

Conversation

renefs
Copy link
Contributor

@renefs renefs commented Oct 22, 2024

This issue resolves #490 .

  1. When the timeline is clicked, a new slot with the default duration is added.
  2. A tooltip is displayed on mouse hover to indicate the position in the timeline.
  3. The granularity is set to 15 minutes, but it can be changed using the time picker.
Screen.Recording.2024-10-22.at.09.28.58.mov

@renefs renefs changed the title Use mouse click to add a new time slot (Solves #490) Use mouse click to add a new time slot (Resolves #490) Oct 22, 2024
@renefs renefs changed the title Use mouse click to add a new time slot (Resolves #490) Use mouse click to add a new time slot Oct 22, 2024
@tomasr8
Copy link
Member

tomasr8 commented Oct 22, 2024

Overall looks good! I just have some points regarding UX:

  • Could we reuse the existing tooltip when hovering over the timeline? There are now two different tooltips which might look a bit off
    obrazek

  • The green area looks a bit different now, was that intentional?
    before:
    obrazek
    after:
    obrazek
    Related to that, it's also more difficult to create parallel timeslots because of the reduced padding (there's only a tiny spot at the bottom where you can click):
    obrazek

  • Maybe we could use cursor: pointer to make it more obvious that you can click on the timeline?

  • The tooltip renders when you hover the + button:
    obrazek

As I mentioned here, maybe we could render a silhouette when simply hovering to make it even more obvious you're supposed to click on the timeline?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make it easier to create timeslots
2 participants