IPX800v4 update #2210
Open
IPX800v4 update #2210
+76
−56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aknotwot
commented
Mar 25, 2025
aknotwot
commented
- typo in drivers.xml
- now APIKey field is optionnal
- solving issue on parsing of Analogs Inputs and Digital Outputs
API key is now optionnal. + Correction of JSON parsing for Analog Inputs and Digital outputs.
knro
reviewed
Mar 25, 2025
drivers/io/ipx800v4.cpp
Outdated
| @@ -74,6 +74,9 @@ bool IPX800::initProperties() | |||
| ModelVersionTP.fill(getDeviceName(), "MODEL", "Model", "Main Control", IP_RO, 60, IPS_IDLE); | |||
|
|
|||
| setDefaultPollingPeriod(1000); | |||
|
|
|||
| // Ensure properties are updated | |||
| updateProperties(); | |||
There was a problem hiding this comment.
We cannot call updateProperties in initProperties
knro
reviewed
Mar 25, 2025
drivers/io/ipx800v4.cpp
Outdated
| @@ -83,16 +86,15 @@ bool IPX800::updateProperties() | |||
| INDI::DefaultDevice::updateProperties(); | |||
| InputInterface::updateProperties(); | |||
| OutputInterface::updateProperties(); | |||
|
|
|||
| defineProperty(APIKeyTP); | |||
There was a problem hiding this comment.
If this property needs to exist all the time, then it needs to be moved to ISGetProperties function instead. Properties defined there exist for the lifetime of the driver regardless of the connection status.
There was a problem hiding this comment.
My tested proposal. it works.
void IPX800::ISGetProperties(const char *dev)
{
INDI::DefaultDevice::ISGetProperties(dev);
//Define the APIKeyTP property
APIKeyTP[0].fill("API_KEY", "API Key", "");
APIKeyTP.fill(getDeviceName(), "API_KEY", "API Settings", MAIN_CONTROL_TAB, IP_RW, 60, IPS_IDLE);
defineProperty(APIKeyTP);
APIKeyTP.load();
}
If this modification is ok for you, should i do a new pull request, to merge it ? or is it possible to modify this one ?
There was a problem hiding this comment.
This should be in initProperties:
APIKeyTP[0].fill("API_KEY", "API Key", "");
APIKeyTP.fill(getDeviceName(), "API_KEY", "API Settings", MAIN_CONTROL_TAB, IP_RW, 60, IPS_IDLE);
APIKeyTP.load();
This should be in ISGetProperties:
INDI::DefaultDevice::ISGetProperties(dev);
defineProperty(APIKeyTP);
Implementation of ISGetProperties for APIKeyTP declaration.
|
Commit added (use of ISGetProperties) the pull request |
APIKeyTP init moved to initProperties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.