Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Title: Refactored database table creation into FastAPI startup event
Description:
The database tables were created using Base.metadata.create_all() at the top-level script. This can lead to unexpected behaviors in production or during test runs.
Fixes:
Moved the table creation logic into a FastAPI @app.on_event("startup") function to ensure tables are only created when the app start
2. Title: Added CORS middleware support for frontend integration
Description:
To allow cross-origin requests from the frontend (e.g., React/Vue app), CORS headers has be added. Without CORS middleware, requests from different origins (e.g., frontend on localhost:3000) may be blocked.
Fixes:
Used FastAPI’s CORSMiddleware to enable cross-origin requests.
3. Title: Enhanced Swagger UI with route tags
Description:
The routes in Swagger (docs) were ungrouped. Adding tags while including routers will help organize them logically and improve developer usability.
Fixes:
Used:
app.include_router(favorites.router, tags=["Favorites"])