Update tag propagation logic #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-alveyblanc
commented
Apr 22, 2024
|
Looks like pylint and mypy are failing even though the changes in inducer/pytools#220 have been merged. They don't fail locally 🤷♂️ |
|
Needs a pytools release, I'll make one. |
|
We should add a dependency on that version in |
|
Added dependency on |
inducer
reviewed
Sep 5, 2024
pytato/transform/metadata.py
Outdated
| # }}} | ||
|
|
||
|
|
||
| class IgnoredForPropagationTag(Tag): |
There was a problem hiding this comment.
- Include in docs.
- Explain the semantics.
- Add a use case/justification for why one might possibly want this.
inducer
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IgnoredForPropagationTagin tag propagation