Fix Undefined property: Inertia\Response::$headers

[SuperDJ]

Fix #113

[pascalbaljet]

What I don't understand is, given that Inertia\Response implements Responsable, why isn't toResponse() called after the then() callback in the first place?

[SuperDJ]

@pascalbaljet tried adding a test to reproduce the errors. When seeing the error it's always when redirecting from one page to a modal page that has a baseRoute that is different from the redirecting page. Lets say from index your redirect to users.edit (a modal) with a baseRoute of users.show. If that isn't giving you any errors, it might be a conflict between used packages. For example stancl/tenancy is used but might conflict.

[SuperDJ]

@pascalbaljet if it helps these are the gathered middleware:

taken from dd($this->gatherMiddleware($route));

[SuperDJ]

@pascalbaljet is the DispatchBaseUrlRequest supposed to run multiple times? In the error it runs once and passes the Inertia\Middleware

at a later stage it fails to pass Inertia\Middleware due to the error

[ndijkstra]

I'm having the same issue since 0.20.1. This is also in combination the tenancy package

[SuperDJ]

@ndijkstra does my proposed fix work for you as well?

[ndijkstra]

Yes, it will solve the error about the $headers. But sending data with a reload is still not working for me, but not sure if this issue is related

[SuperDJ]

@ndijkstra you mean with a partial reload? I haven't tested that. Does that throw an error with the $headers as well?

[ndijkstra]

@ndijkstra you mean with a partial reload? I haven't tested that. Does that throw an error with the $headers as well?

My partial reload error is not related to this error. Your PR will solve the issue related to the $headers exception

[SuperDJ]

If someone is interested, a temporary package with this fix applied is available here.

[pascalbaljet]

I've investigated this PR and the issue (#113) once more, and I still can't figure out the problem. Also, the newly added test makes the wrong assertion:

$response = $this->from('/users/'.$user->id)
    ->get('/users/'.$user->id.'/edit');

$response->assertOk()
    ->assertInertia(fn (AssertableInertia $page) => $page
        ->component('ShowUser')
        ->url('/users/'.$user->id.'/edit')
        ->has('_inertiaui_modal', fn (AssertableInertia $assert) => $assert
            // ...
            ->where('baseUrl', '/users')
        )
    );
}

The baseUrl should be '/users/'.$user->id since that's the page from which you're requesting the modal. The component assertion (ShowUser) is correct, though, so the baseUrl and component contradict.

Would it be possible to add a (failing) Dusk test for this? That would make it a bit more visual to see what's happening.