Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FI-2493: Add references to PractitionerRole resources #141

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

dehall
Copy link
Contributor

@dehall dehall commented Mar 22, 2024

Summary

Adds a couple references to PractitionerRole resources that already exist in the system resources, so that the US Core test kit can find them. Previously there were no outgoing references to the PractitionerRole resources, only references from the PractitionerRole to a Practitioner.

Testing guidance

The US Core 6.1.0 and 7.0.0-ballot test suites should now pass on PractitionerRole tests; previously they were skipped for "no data". Nothing should break on these or any versions, in particular the MedicationDispense tests shouldn't break due to these new additions.

Make sure to clear out the DB prior to running the reference server so the resources are reloaded, or alternatively set the FORCE_LOAD_RESOURCES env var to true.

You can delete the server's data by stopping the containers with docker-compose down and then running docker volume rm inferno-reference-server_fhir-pgdata to remove the existing volume.

@dehall dehall requested a review from yunwwang March 22, 2024 14:50
Copy link
Contributor

@yunwwang yunwwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally. PractitionerRole test group passed

@dehall dehall merged commit 8bd2dba into main Mar 22, 2024
1 check passed
@dehall dehall deleted the fi-2493-practitionerrole branch March 22, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants