Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FI-2429: migrate to HL7 validator wrapper #15

Merged
merged 5 commits into from
May 24, 2024
Merged

Conversation

dehall
Copy link
Contributor

@dehall dehall commented May 3, 2024

Summary

Migrate from the inferno validator wrapper to the HL7 validator wrapper:

  • Inferno validator wrapper is commented instead of completely removed in case someone wants the UI again
  • Bumped inferno_core gem
  • Ignore message "URL value does not resolve"
  • Remove the url field from the validator definition block since we are standardizing on just the default FHIR_RESOURCE_VALIDATOR_URL env var now
  • This IG does not seem to be published that I can see, so the validator definition block points to the local file. This should be the same filename as is currently deployed so no special action needed there
  • Convert validator response to OperationOutcome in the reference_resolution test

Testing Guidance

I'm not sure this test kit can actually be run successfully since I'm getting purple errors on prod. https://inferno.healthit.gov/suites/c19-vci/bOoYIoiWyZV#1

@dehall dehall requested a review from Jammjammjamm May 23, 2024 13:17
@dehall
Copy link
Contributor Author

dehall commented May 23, 2024

@Jammjammjamm requesting your review on this one because of the purple errors, hoping you know more about how to get this test kit to run

Copy link
Contributor

@Jammjammjamm Jammjammjamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The minimum version of core in the gemspec needs to be bumped to a version that supports the new validator.

@dehall
Copy link
Contributor Author

dehall commented May 23, 2024

Updated to the latest as of today, 0.4.37. I didn't catch that before so I'll update that on the other test kits too.

@dehall dehall merged commit 2b68e2b into main May 24, 2024
2 checks passed
@dehall dehall deleted the fi-2429-hl7-validator branch May 24, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants