refactor(post-search): collect at least 2 documents from each query source #948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ource This commit refactors the code that evenly collects documents from query sources to let it collect at least 2 documents in every source, which could correct the case when `max_hits_per_source` is 0. This was possible with the previous impl, no longer allowed after this commit
ayangweb
approved these changes
Oct 27, 2025
RainyNight9
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refactors the code that evenly collects documents from query sources to let it collect at least 2 documents in every source, which could correct the case when
max_hits_per_sourceis 0. This was possible with the previous impl, no longer allowed after this commitStandards checklist