Reverse proxy example #406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tristantarrant would you have time for a look here please ? |
karesti
requested review from
pruivo
and removed request for
tristantarrant
|
@pruivo small review and merge ? |
|
It works great! I have one concern about using basic auth without TLS, as it is not secure and exposes credentials. Are we ok with it? cc @karesti @tristantarrant |
|
@pruivo I was thinking that this is valid for demo purpose, but in real world things should be diff. but I don't want to add that overhead into this example, I want to nail down to the most simple and then write a blog post / guide on this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #405