chore: produce config builder as mutable #4375
Open
+64
−96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fraidev
force-pushed
the
producer_config_builder_clone
branch
from
3e93de3 to
c4a9f0e
Compare
fraidev
changed the title
sehz
reviewed
Feb 2, 2025
| } else { | ||
| Default::default() | ||
| let mut config_builder = TopicProducerConfigBuilder::default(); | ||
| if self.interactive_mode() { |
There was a problem hiding this comment.
do we still need interactive mode?
digikata
reviewed
Feb 3, 2025
| pub fn set_specific_partitioner(self, partition_id: PartitionId) -> Self { | ||
| self.partitioner(Box::new(SpecificPartitioner::new(partition_id))) | ||
| pub fn set_specific_partitioner(&mut self, partition_id: PartitionId) -> &mut Self { | ||
| self.partitioner(Arc::new(SpecificPartitioner::new(partition_id))) |
There was a problem hiding this comment.
| Perhaps we should make this Arc Box? It may be important in long running or high concurrency uses
same as previous line
digikata
reviewed
Feb 3, 2025
| @@ -88,7 +88,7 @@ pub struct TopicProducerConfig { | |||
| pub(crate) linger: Duration, | |||
| /// Partitioner assigns the partition to each record that needs to be send | |||
| #[builder(default = "default_partitioner()")] | |||
| pub(crate) partitioner: Box<dyn Partitioner + Send + Sync>, | |||
| pub(crate) partitioner: Arc<dyn Partitioner + Send + Sync>, | |||
There was a problem hiding this comment.
Perhaps we should make this Arc Box? It may be important in long running or high concurrency uses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TopicProducerConfigBuilder was created as owner, making it very difficult to handle and create wrappers for python client.
I changed this builder to the default behavior (mutable).