Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add orientation to encoder builder (passed on to basicinfo) #130

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Matthias-Fauconneau
Copy link

I'm using num-enum in sys to impl TryFrom for Orientation but you might prefer to add an enum in -rs instead with a conversion method.

@inflation
Copy link
Owner

inflation commented Jan 27, 2025

Yes, I would prefer to not introduce another dependency for such a small change. Also, the encoding speed enum is from libjxl and could add extra validation upon usage.

I'm also including the Cargo.lock file to speed up CI and MSRV checks: https://blog.rust-lang.org/2023/08/29/committing-lockfiles.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants