Open
Conversation
a5a3acf to
967f281
Compare
Sl1mb0
commented
Feb 10, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Implements POSIX/WASI-like open_at behavior in the in-memory VFS so guests can open existing nodes and create/truncate files (a prerequisite for enabling host-side FS writes), and updates unit/integration tests to reflect the new semantics.
Changes:
- Refactors VFS path resolution and expands
VfsCtxView::open_atto handleCREATE,EXCLUSIVE,DIRECTORY, andTRUNCATE. - Adds extensive unit tests around
open_atbehavior and updates integration test expectations/snapshots. - Makes
Limiter::growtake&self(internally synchronized), simplifying ownership/mutability in component setup.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| host/src/vfs/mod.rs | Implements new open_at semantics, factors path traversal helper, and adds unit tests. |
| host/src/limiter.rs | Changes grow to &self to allow shared use behind a mutex. |
| host/src/component.rs | Adjusts limiter initialization to match the new Limiter::grow signature/usage. |
| host/tests/integration_tests/python/runtime/fs.rs | Updates Python FS integration test to exercise create-on-open behavior. |
| host/tests/integration_tests/evil/fs.rs | Updates large snapshot expectations for new VFS/open behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
d7bd5c4 to
adb81f9
Compare
c06aaab to
eca54f2
Compare
Contributor
Author
|
This is a massive PR but most of the diffs are in the tests; the actual implementation is fairly minimal. |
mhilton
approved these changes
Feb 10, 2026
crepererum
reviewed
Feb 11, 2026
162426f to
2a96695
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #336
I followed the specification described here. Given that we will eventually need to test this against the wasi test-suite, any differences between the aforementioned spec and the test-suite will favor the test-suite; so significant changes may need to be made in the future.
Describe your proposed changes here.