feat: Call SingleGenerationReason() once by initializing a

var called SingleGenerationReasonText var
influxdata · Dec 19, 2024 · fc6ca13 · fc6ca13
1 parent cf657a8
commit fc6ca13
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/tsdb/config.go b/tsdb/config.go
@@ -84,9 +84,10 @@ const (
 
 	// MaxTSMFileSize is the maximum size of TSM files.
 	MaxTSMFileSize = uint32(2048 * 1024 * 1024) // 2GB
-
 )
 
+var SingleGenerationReasonText string = SingleGenerationReason()
+
 // SingleGenerationReason outputs a log message for our single generation compaction
 // when checked for full compaction.
 // 1048576000 is a magic number for bytes per gigabyte.

diff --git a/tsdb/engine/tsm1/compact.go b/tsdb/engine/tsm1/compact.go
@@ -248,7 +248,7 @@ func (c *DefaultPlanner) FullyCompacted() (bool, string) {
 			}
 
 			if filesUnderMaxTsmSizeCount > 1 && aggressivePointsPerBlockCount < len(gens[0].files) {
-				return false, tsdb.SingleGenerationReason()
+				return false, tsdb.SingleGenerationReasonText
 			}
 		}
 		return true, ""

diff --git a/tsdb/engine/tsm1/compact_test.go b/tsdb/engine/tsm1/compact_test.go
@@ -2487,7 +2487,7 @@ func TestDefaultPlanner_FullyCompacted_SmallSingleGeneration(t *testing.T) {
 	cp := tsm1.NewDefaultPlanner(fs, tsdb.DefaultCompactFullWriteColdDuration)
 
 	compacted, reason := cp.FullyCompacted()
-	require.Equal(t, reason, tsdb.SingleGenerationReason(), "fullyCompacted reason")
+	require.Equal(t, reason, tsdb.SingleGenerationReasonText, "fullyCompacted reason")
 	require.False(t, compacted, "is fully compacted")
 
 	_, cgLen := cp.PlanLevel(1)
@@ -2607,7 +2607,7 @@ func TestDefaultPlanner_FullyCompacted_LargeSingleGenerationUnderAggressiveBlock
 
 	cp := tsm1.NewDefaultPlanner(fs, tsdb.DefaultCompactFullWriteColdDuration)
 	compacted, reason := cp.FullyCompacted()
-	require.Equal(t, reason, tsdb.SingleGenerationReason(), "fullyCompacted reason")
+	require.Equal(t, reason, tsdb.SingleGenerationReasonText, "fullyCompacted reason")
 	require.False(t, compacted, "is fully compacted")
 
 	_, cgLen := cp.PlanLevel(1)