Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade golang 1.19.10 -> 1.20.10 (1.x) #24413

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

bnpfeife
Copy link
Contributor

No description provided.

@bnpfeife bnpfeife self-assigned this Oct 11, 2023
@alespour alespour self-requested a review October 12, 2023 08:33
alespour
alespour previously approved these changes Oct 12, 2023
Copy link
Contributor

@alespour alespour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just why not use go1.20.10-latest tag instead?

@alespour
Copy link
Contributor

go.mod Outdated
golang.org/x/mod v0.6.0-dev.0.20220419223038-86c51ed26bb4 // indirect
golang.org/x/net v0.7.0 // indirect
golang.org/x/mod v0.13.0 // indirect
golang.org/x/net v0.16.0 // indirect
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get this updated to v0.17.0? See https://github.com/advisories?query=GHSA-4374-p667-p6c8

@bnpfeife bnpfeife force-pushed the BNP_upgrade-golang-1.20.10_1.x branch from b352a51 to f9514e6 Compare October 12, 2023 15:44
@bnpfeife bnpfeife merged commit 7f68cd1 into master-1.x Oct 12, 2023
1 check passed
@bnpfeife bnpfeife deleted the BNP_upgrade-golang-1.20.10_1.x branch October 12, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants