Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inputs.webhooks): Add support for GitHub workflow events #16355

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

DeusDeorum1
Copy link

@DeusDeorum1 DeusDeorum1 commented Dec 29, 2024

Summary

inputs.webhooks.github now accepts workflow_job and workflow_run events from Github
Collects run_attempts, execution time, head_branch, name and conclusion for jobs and workflow runs. Also collects queue time for jobs

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #16354

@telegraf-tiger
Copy link
Contributor

Thanks so much for the pull request!
🤝 ✒️ Just a reminder that the CLA has not yet been signed, and we'll need it before merging. Please sign the CLA when you get a chance, then post a comment here saying !signed-cla

@DeusDeorum1
Copy link
Author

!signed-cla

@DeusDeorum1 DeusDeorum1 changed the title [WIP] feat(inputs.webhooks): Add inputs.webhooks.github workflow events support feat(inputs.webhooks): Add inputs.webhooks.github workflow events support Dec 29, 2024
@DeusDeorum1 DeusDeorum1 marked this pull request as ready for review December 29, 2024 20:21
@telegraf-tiger telegraf-tiger bot added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Dec 29, 2024
@srebhan
Copy link
Member

srebhan commented Jan 17, 2025

@DeusDeorum1 could you please fix the linter issues!? You can also reproduce them locally running make lint-install (in case you don't have the linter installed) and make lint afterwards...

@srebhan srebhan self-assigned this Jan 17, 2025
@DeusDeorum1
Copy link
Author

@srebhan Hi! Sure thing, I’ll fix them soon. Just didn‘t have free time for that lately

@telegraf-tiger
Copy link
Contributor

@srebhan srebhan changed the title feat(inputs.webhooks): Add inputs.webhooks.github workflow events support feat(inputs.webhooks): Add support for GitHub workflow events Jan 29, 2025
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DeusDeorum1!

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jan 29, 2025
@srebhan srebhan assigned DStrand1 and unassigned srebhan Jan 29, 2025
@DeusDeorum1
Copy link
Author

@srebhan Hi! I've fixed linter errors but encountered integration tests fail which does not seem to be related to my changes. Is is a know issue introduced somewhere else or it's something to be addressed in this PR?

@srebhan
Copy link
Member

srebhan commented Jan 31, 2025

@DeusDeorum1 the integration test failure is fixed in master and unrelated to your PR. Just ignore it.

@DeusDeorum1
Copy link
Author

@srebhan Got it! Then the PR should be ready for a code review :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

github webhook workflow events support
3 participants