refactor(statsd receiver): rename Statsd.UDPlistener => UDPConn #16420
Conversation
|
Thanks so much for the pull request! |
…ruct Summary: Later in this stack of diffs, I add a field named `MaxConnections` to `Statsd` because it controls the max number of connections for all listener types, not just TCP listeners. That creates a naming collision with the existing field named `MaxConnections`, which is an internal stat tracker. This diff eliminates that name collision by encapsulating all of `Statsd`'s internal stat trackers in a struct. Test Plan: Existing unit tests pass.
Summary: Later in this stack of diffs, I rename `TCPlistener` to `Listener` because it becomes a generic listener for all networks supported by `net.Listen`. That makes `UDPlistener`'s naming stand out because: - It isn't a listener. It's a `*net.UDPConn`. - It isn't the UDP counterpart to `Listener`. This diff renames it to `UDPConn` to improve clarity. Test Plan: Unit tests pass.
Manbeardo
changed the title
|
!signed-cla |
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
There was a problem hiding this comment.
@Manbeardo this PR does two things it renames the UDPlistener and introduces a stats substructure. Please split the PR into two separate things!
|
This PR is stacked on top of #16419. I'm not sure why GitHub hasn't updated the diff, but the stats stuff has already been merged. |
Summary:
Later in this stack of diffs, I rename
TCPlistenertoListenerbecause it becomes a generic listener for all networks supported bynet.Listen. That makesUDPlistener's naming stand out because:*net.UDPConn.Listener.This diff renames it to
UDPConnto improve clarity.Test Plan:
Unit tests pass.
Stack created with Sapling. Best reviewed with ReviewStack.