PTOCP-1121 - Update authz middleware to not redact the JWT token #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsatal
requested review from
rchowinfoblox and
drewwells
and removed request for
drewwells and
rchowinfoblox
rchowinfoblox
requested changes
Jul 15, 2024
There was a problem hiding this comment.
LGTM, but please also remove jwt-redaction in v1 of the middleware (prob need separate PR):
https://github.com/infobloxopen/atlas-authz-middleware/blob/main/grpc_opa/authorizer.go#L221
Created another PR for V1- #41 |
drewwells
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update authz middleware not to redact the JWT token. The JWT validation needs a complete JWT token instead of the redacted one in the OPA container.