Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding v levels to debug logs #189

Merged
merged 1 commit into from
Oct 3, 2023
Merged

adding v levels to debug logs #189

merged 1 commit into from
Oct 3, 2023

Conversation

ssuman2-infoblox
Copy link
Contributor

adding V level to debug logs so they only appear in debug mode.

Added as per controller-runtime's logging documentation here

abalaven
abalaven reviewed Oct 2, 2023
View reviewed changes
Copy link
Contributor

@abalaven abalaven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Maybe you can plug a flag in the helm chart to dynamically control the value based on the env.

@ssuman2-infoblox
Copy link
Contributor Author

Nice work! Maybe you can plug a flag in the helm chart to dynamically control the value based on the env.

Thanks @abalaven , I updated the PR to do this. Please review.
For ref: https://pkg.go.dev/sigs.k8s.io/controller-runtime/pkg/log/zap@v0.14.1#Options

@ssuman2-infoblox ssuman2-infoblox marked this pull request as ready for review October 3, 2023 16:32
@abalaven abalaven merged commit 1a356be into main Oct 3, 2023
3 checks passed
@abalaven abalaven deleted the log-levels branch October 3, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjeevan-ib bjeevan-ib bjeevan-ib approved these changes

@abalaven abalaven Awaiting requested review from abalaven

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ssuman2-infoblox @bjeevan-ib @abalaven