Change return value and type for UpdateTXTRecord. Fixes #113 #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| return &res[0], nil | ||
| return ref, nil |
There was a problem hiding this comment.
I would suggest returning of pointer to the object by updating the reference of the object beforehand.
| } | ||
|
|
||
| res[0].Text = text | ||
|
|
||
| res[0].Zone = "" // set the Zone value to "" as its a non writable field | ||
|
|
||
| _, err = objMgr.connector.UpdateObject(&res[0], res[0].Ref) | ||
| ref, err := objMgr.connector.UpdateObject(&res[0], res[0].Ref) |
There was a problem hiding this comment.
The reference of the object can be updated after this line.
res[0].Ref=ref
|
As a best practice I also support returning pointer to an object after updating its reference. |
|
Hi @GNewbury1, do you want to roll back this PR ? |
|
Closing this PR as of now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #113 by returning the reference to the new object when calling UpdateTXTRecord