Feature Branch for ib go client migration #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Updated some of the field usages, since many of the fields in new client are now references instead of original objects. * Updated some terraform-plugin-sdk dependencies to run acceptance tests.
* Updated terraform-plugin-sdk dependency from v2.4.3 to v2.27.0.
* Implemented a new way to search for a network resource using filters. EA search is supported by appending asterisk to the search key.
* Rewrote read schema and logic for network container data source. Search by extensible attributes is now available for this data source. * Fixed small bugs for network data source
* Rewrote read schema and logic for network view data source. Search by extensible attributes is now available for this data source.
* Version v2.27.0 is not compatible with go 1.17, which is used to compile this terraform provider.
* Some checks were failing because of updated field types in CNAME record struct.
* Changed 'ext_attrs' field type from String to Map. * Added extAttrsDiffSuppressFunc to suppress diff for EA entry, if state value is provided, but config value is not provided (e.g. in case of EA inheritance). * Created acceptance test to validate that terraform provider won't try to remove EAs, that added by outside tool (e.g. NIOS in case of EA inheritance).
* In case, if inherited EA is specified in configuration, it should be overridden by terraform.
* Previous solution containing a diff suppress function had a problem with EA delete operations, since diff suppress function doesn't have the access to actual API object state. * Now, inherited EAs are omitted on the read stage and added back on the update stage. * Added two helper functions for serialization and deserialization EAs into/from JSON formatted string, which is usually used as a value of 'ext_attrs' fields.
…into feature/ib_go_client_migration
* This resource could be used for creating EA definition (e.g. in acceptance tests).
…into feature/ib_go_client_migration
* Now inherited EAs won't be removed by terraform on a second apply step.
…into feature/ib_go_client_migration
…into feature/ib_go_client_migration
ranjishmp
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes changes from feature branch, where new features and modifications are done.
Listing Items: