Add integration test for testing client recovery #176

seanchen1991 · 2024-04-18T19:37:14Z

Closes: #173

rnbguy

I added review comments.

Thanks for taking care of client recovery and transaction submission support ! 🚀

basecoin/modules/src/gov/impls.rs

basecoin/src/tx/mod.rs

basecoin/src/cli/command.rs

basecoin/src/tx/key_pair.rs

basecoin/src/tx/mod.rs

rnbguy · 2024-04-26T12:25:30Z

Takes the latest commit from cosmos/ibc-rs#1197 to make sure e2e tests pass at basecoin-rs side 🚀

rnbguy

Great work, Sean ! 🚀

I updated the ibc-rs commit rev from main branch. When the CI passes, this can be merged.

seanchen1991 added 30 commits March 26, 2024 10:51

Implementing deliver method for client recovery

6b93844

Implement deliver method

12b8715

Add todo comment

95a9156

Fix merge conflicts

b4896bc

Implement RecoverCmd

ca73d99

Making progress on submit_recovery_proposal

b9d3b01

Progress on client recovery testing functionality

8363c13

Print tx::send_tx error

bea90ef

Fix dependency issues

b7956b2

Stub out recover-client.sh

a47f3de

Remove global = true from RecoverCmd

92ca564

First iteration of recover-client.sh

685f7af

Remove unused error variants

b027452

Remove unneeded dependency

def2ee4

Fix merge conflicts

895dffa

Fix merge conflicts

eaafa90

Remove extraneous use

1fa6026

Add some echo statements

8ba7aa3

Add recover-client test to Makefile

0d0a14d

Edit Makefile

981d54e

Change order of tests around

e8ecdd8

Fix typo in makefile

19d8887

Use default hermes config file in recover-client.sh

3101a85

Update basecoin dependency revs

e04dd4c

Revert create client commands to use recovery config

80ccc0d

Make changes to integration.yml

45bae32

Make changes to integration.yml

a1f1726

Point cargo install command to basecoin directory

374849f

Fix basecoin validation command

8c8b5ae

Tweak cargo install path

ed68437

rnbguy added 16 commits April 26, 2024 11:29

refactor tx submission

599fd87

derive path and seed file as cli args

db928c1

require seed_file

ac78535

use .git url

a1a90bb

separate tower-abci dep

1e07a70

nit on toml file

3ce4d31

add comment

53b3b94

rm redundant trait bound

9c848dd

impl Coin::from_str

e5566cb

add more arguments to tx command

1df3d16

use cli args

04699be

rm redundant util funcs

e555934

update cargo lockfile

b48abf8

default chain id

46b2213

add memo cli arg

f95b435

nit

b0ac4ec

rnbguy requested changes Apr 26, 2024

View reviewed changes

rnbguy added 3 commits April 26, 2024 14:23

latest rev

7a7f55b

use AnyClientState

6ac934e

update cargo lockfile

6a3b8e0

seanchen1991 and others added 6 commits April 26, 2024 09:16

Incorporate some PR feedback

c6ea1fd

Incorporate some PR feedback

d87bbd2

Switch from using Message::encode to Message::encode_to_vec

5749e90

Add comment about client recovery operation not returning an event

e13d5c6

Use shorted github rev link in comment

0132731

ibc-rs rev from main

550d90f

rnbguy approved these changes Apr 26, 2024

View reviewed changes

rnbguy merged commit 8496b3f into main Apr 26, 2024
10 checks passed

rnbguy deleted the sean/client-recovery branch April 26, 2024 15:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add integration test for testing client recovery #176

Add integration test for testing client recovery #176

seanchen1991 commented Apr 18, 2024

rnbguy left a comment

rnbguy commented Apr 26, 2024

rnbguy left a comment

Add integration test for testing client recovery #176

Add integration test for testing client recovery #176

Conversation

seanchen1991 commented Apr 18, 2024

rnbguy left a comment

Choose a reason for hiding this comment

rnbguy commented Apr 26, 2024

rnbguy left a comment

Choose a reason for hiding this comment