-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
imp: investigate why upgrade-client halts gaiad
#178
Conversation
Looks like, there is consensus failure at
|
c536af0
to
bef2d5d
Compare
bef2d5d
to
8d8e8d7
Compare
gaiad
Latest changes now log the error directly on workflow. cc @ljoss17 |
The error is coming from cosmos/cosmos-sdk/x/upgrade/keeper/abci.go#L79. That means the upgrade plan does not set any handler. We are using the default |
We need to recompile the binary with a handler for the plan. I think it'll be fine to cancel the software upgrade somehow. There is a subcommand |
It looks like the We may only run the grpc-service after it, as it doesn't involves |
dbb8c6b
to
16b4a9a
Compare
gaiad
gaiad
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Makes sense moving the upgrade client test to the end of the testing order 👍
Closes #177
HealthService::get_syncing
.one-chain
script toone-chain.sh
.