Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infer compatibility mode from version specs and fallback to node info only if necessary #4181

Merged
merged 6 commits into from
Sep 5, 2024
Merged

Infer compatibility mode from version specs and fallback to node info only if necessary #4181

merged 6 commits into from
Sep 5, 2024

Conversation

romac
Copy link
Member

@romac romac commented Sep 3, 2024 •
edited
Loading

Closes: #4178

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@romac romac mentioned this pull request Sep 3, 2024
Closed
5 tasks
@romac romac marked this pull request as ready for review September 3, 2024 11:26
@romac romac merged commit aeca07b into master Sep 5, 2024
30 checks passed
@romac romac deleted the romac/compat-mode-fetch branch September 5, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Undefined behaviour with compat_mode 0.37
1 participant
@romac