Put clone() to where it is needed #4209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romac
reviewed
Oct 3, 2024
There was a problem hiding this comment.
In general if a function requires unconditional ownership of a value, it should make this explicit in its signature and take an owned type. That said, in this case it doesn't hurt too much to do it third way so I'll leave it up to @ljoss17 to decide which version he prefers.
|
Let's go with this solution as it looks a bit cleaner |
|
Applied cargo fmt |
romac
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
Description
Put clone() to where it is needed
PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.