Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: Fix AppHash decoding failure in /block_results response #1449

Merged
merged 3 commits into from
Jul 23, 2024

Conversation

ljoss17
Copy link
Contributor

@ljoss17 ljoss17 commented Jul 23, 2024

Closes: #1447

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Added entry in .changelog/

@ljoss17 ljoss17 marked this pull request as ready for review July 23, 2024 09:59
Co-authored-by: Romain Ruetschi <romain@informal.systems>
@ljoss17 ljoss17 merged commit 58ff766 into main Jul 23, 2024
23 checks passed
@ljoss17 ljoss17 deleted the luca_joss/decode-app-hash-with-base64 branch July 23, 2024 10:27
ChronosXYZ added a commit to cytonic-network/cometbft-rs that referenced this pull request Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fail to decode AppHash from /block_results response
2 participants