Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat null value of json the same as other types #1002

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Conversation

RFSH
Copy link
Member

@RFSH RFSH commented Feb 2, 2024

This PR will apply the change described here.

We should stop treating json/jsonb columns differently in read-only modes. So, a null value should be treated like a database null, and therefore, we should honor the show_null annotation for it (instead of forcefully showing the null in a code block).

The other changed mentioned in the comment required more changes, so I decided to not include it in the same PR.

@RFSH RFSH self-assigned this Feb 2, 2024
@RFSH RFSH merged commit c2c4942 into master Feb 2, 2024
1 check passed
@RFSH RFSH deleted the json-null-changes branch February 2, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant