Format scientific float #1007
Merged
Format scientific float #1007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this PR are intended to improve how we are displaying formatted float values when no pre-format annotation is provided. We noticed the browser will automatically change a
numberafter a certain threshold to display in scientific notation.We discussed in our meeting with Hongsuda that the thresholds for our code should be 1 trillion (or more than 12 digits) and
0.0000007(or more than 6 decimal places before the first non zero digit is present).I noted in the code that this is still not ideal since there is a range where some values won't "display" since our default display is
4digits after the zero. So when there are 5 or 6 digits after the zero, the digits in the 5th and 6th place might be lost when displayed. The workaround for this is to use the pre-format annotation. This limitation exists in the code before this branch is merged. If this needs to be addressed, we should do it separately and also discuss handling trailing values being truncated too (10000000000001 will have the last 1 changed to a 0).