Facet within facet #1017
Merged
Facet within facet #1017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the previous code was only working with one level of facets and joins, and was breaking when we changed chaise to allow facets within facets.
…o facet-within-facet
I also removed the function that I added in the previous commit but never used.
issues: - fix typos in ermrestCompactPath and _createParsedJoinFromStr - make sure Location constructor uses the correct join. the function was assuming that the first portion of the url always has a facet, but that might not be true.
jrchudy
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the changes required for this PR in chaise. Summary of changes:
max_facet_depthdisplay annotation property, andmaxFaceDepthproperty added tofacetPanelDisplayof chaise-config.FacetColumn.hideNullChoicecan properly find null filters in multi-layer facet (it was just looking at the facets of the current level. But if there's anullfacet anywhere on the URL we cannot allow users to filter by null again).Location.addJointo use the proper alias name. It was due to the same wrong assumption as the previous bullet.Location.ermrestCompactPathand_createParsedJoinFromStr.