-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(survey): Support multiple surveys #194
Open
Andreas02-dev
wants to merge
12
commits into
main
Choose a base branch
from
feature/193-support-multiple-surveys
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 5 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
268afb7
feat(survey): Support multiple surveys
Andreas-InfoSupport 73c7322
refactor(playwright): Allow retries in CI
Andreas-InfoSupport 6102d82
refactor(survey): Remove unused code
Andreas-InfoSupport 5dcb3d2
refactor(survey): Fix lint issues
Andreas-InfoSupport 8ab266b
feat(survey): Support multiple surveys
Andreas-InfoSupport a6ba171
fix(lint): Fix lint warns
Andreas-InfoSupport a48d89c
chore(stress-test): Remove unused stress-test files
Andreas-InfoSupport 65e8ba9
refactor(trpc): Rename `db` to `prismaClient`
Andreas02-dev deefffe
refactor(all): Use non-relative imports
Andreas02-dev 052b249
chore(tsconfig): Stricter checks
Andreas02-dev efd3e74
refactor(all): Use existing filename-convention (kebab)
Andreas02-dev 6836050
fix(homepage-buttons): Fix find-the-expert URL on home-page
Andreas02-dev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,8 @@ | ||
{ | ||
"recommendations": [ | ||
"esbenp.prettier-vscode", | ||
"streetsidesoftware.code-spell-checker", | ||
"ms-playwright.playwright" | ||
] | ||
"recommendations": [ | ||
"esbenp.prettier-vscode", | ||
"streetsidesoftware.code-spell-checker", | ||
"ms-playwright.playwright", | ||
"prisma.prisma" | ||
] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 changes: 15 additions & 0 deletions
15
prisma/migrations/20250306125830_add_surveydate_to_survey/migration.sql
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
/* | ||
Warnings: | ||
|
||
- Added the required column `surveyDate` to the `Survey` table without a default value. This is not possible if the table is not empty. | ||
|
||
*/ | ||
|
||
-- Add the surveyDate column as nullable | ||
ALTER TABLE "Survey" ADD COLUMN "surveyDate" DATE NULL; | ||
|
||
-- Update the 2024 survey to have a surveyDate | ||
UPDATE "Survey" SET "surveyDate" = '2024-01-01' WHERE "surveyDate" IS NULL; | ||
|
||
-- Alter the surveyDate column to be non-nullable | ||
ALTER TABLE "Survey" ALTER COLUMN "surveyDate" SET NOT NULL; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's ask @nicojs about this:
There are two options here.
Option 1: Keep it as it is, searching by name. The url will be
https://.../profile-page?name=Jelle%20Buitenhuis
. However, names are not guaranteed to be unique, how would we handle that?Option 2: Change it to
userId
, which is guaranteed to be unique. The url will behttps://.../profile-page?id=cm893klj4h353457
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could also use metadata to show the name of the user, social media apps also use this for link previews.
Quick code example would be:
Which would look something like:
