Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(geo): ensure the store contains map before bind to stores list #1582

Open
wants to merge 2 commits into
base: next
Choose a base branch
from
Open

fix(geo): ensure the store contains map before bind to stores list #1582

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2249eb0
fix(geo): ensure the store contains map before bind to stores list
aziz-access Jan 16, 2024
5f4174a
delete ligne
aziz-access Jan 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/geo/src/lib/feature/shared/strategies/in-map-resolution.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@ export class FeatureStoreInMapResolutionStrategy extends EntityStoreStrategy {
* @param store Feature store
*/
bindStore(store: FeatureStore) {
if (!store && !store.layer && !store.layer.map) {
return;
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On semble simplement ignorer l'erreur plutot que de la corriger. Quel est la source du problème?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je n'arrive pas à comprendre exactement la source du problème, car je n'ai pas suffisamment d'informations. donc j'ai ignorer l'erreur.
la seule chose que je comprends c'est que la valeur du store parfois undefined

super.bindStore(store);
if (this.active === true) {
this.watchStore(store);
Expand Down
4 changes: 2 additions & 2 deletions packages/geo/src/lib/filter/shared/ogc-filter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -594,8 +594,8 @@ export class OgcFilterWriter {
const srsName = igoOgcFilterObject.hasOwnProperty('srsName')
? igoOgcFilterObject.srsName
: proj
? proj.getCode()
: 'EPSG:3857';
? proj.getCode()
: 'EPSG:3857';

return Object.assign(
{},
Expand Down