Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to golang 1.20 (#127) #128

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Move to golang 1.20 (#127) #128

merged 1 commit into from
Jan 9, 2024

Conversation

csibbitt
Copy link
Contributor

@csibbitt csibbitt commented Jan 8, 2024

  • Move to golang 1.20

  • Bump golangci-lint to 1.51 for golang 1.20 support

(cherry picked from commit 35d6fbe)

@csibbitt
Move to golang 1.20 (#127)
8d4e394 
* Move to golang 1.20

* Bump golangci-lint to 1.51 for golang 1.20 support

(cherry picked from commit 35d6fbe)
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2024

Coverage Status

@leifmadsen
Copy link
Member

I'm surprised this wasn't merged as part of the STF 1.5.3 work. Did we not end up importing master to stable-1.5 in 1.5.3? (no other changes?)

@leifmadsen
Copy link
Member

I'm surprised this wasn't merged as part of the STF 1.5.3 work. Did we not end up importing master to stable-1.5 in 1.5.3? (no other changes?)

Oh this was only merged 3 weeks ago, which is well after 1.5.3 was tagged. Is there a need to backport this now vs just waiting for STF 1.5.4 and importing master to stable-1.5 at that time?

@leifmadsen
Copy link
Member

I'm surprised this wasn't merged as part of the STF 1.5.3 work. Did we not end up importing master to stable-1.5 in 1.5.3? (no other changes?)

Oh this was only merged 3 weeks ago, which is well after 1.5.3 was tagged. Is there a need to backport this now vs just waiting for STF 1.5.4 and importing master to stable-1.5 at that time?

Never mind, I found the answer in an email I got 3 mins ago. Thanks!

vkmc
vkmc approved these changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@vkmc vkmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vkmc vkmc merged commit ccfe248 into stable-1.5 Jan 9, 2024
17 checks passed
@vkmc vkmc deleted the csibbitt/STF-1660_golang_1.20_cp15 branch January 9, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkmc vkmc vkmc approved these changes

@leifmadsen leifmadsen leifmadsen approved these changes

@vyzigold vyzigold Awaiting requested review from vyzigold

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@csibbitt @leifmadsen @vkmc