Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMP] l10n_ar_account_tax_settlement_mendoza: new module for mendoza AR withholdings #445

Closed
wants to merge 1 commit into from
Closed

[IMP] l10n_ar_account_tax_settlement_mendoza: new module for mendoza AR withholdings #445

wants to merge 1 commit into from

Conversation

pablohmontenegro
Copy link
Contributor

@pablohmontenegro pablohmontenegro commented Sep 9, 2024 •
edited
Loading

Tarea: 38394

@roboadhoc
Copy link
Contributor

Pull request status dashboard.

@pablohmontenegro pablohmontenegro force-pushed the 16.0-38394-pam-2 branch 6 times, most recently from 09db696 to 2618f0b Compare October 3, 2024 17:38
@pablohmontenegro pablohmontenegro force-pushed the 16.0-38394-pam-2 branch 5 times, most recently from d98933f to 63439b1 Compare October 28, 2024 14:38
@pablohmontenegro pablohmontenegro force-pushed the 16.0-38394-pam-2 branch 3 times, most recently from 919308e to e3dad1a Compare October 29, 2024 11:33
zaoral
zaoral suggested changes Oct 29, 2024
View reviewed changes
l10n_ar_txt_mendoza/__init__.py Outdated Show resolved Hide resolved
l10n_ar_txt_mendoza/__manifest__.py Outdated Show resolved Hide resolved
l10n_ar_txt_mendoza/models/account_journal.py Outdated Show resolved Hide resolved
l10n_ar_txt_mendoza/models/account_move.py Outdated Show resolved Hide resolved
l10n_ar_txt_mendoza/models/account_payment.py Outdated Show resolved Hide resolved
@pablohmontenegro pablohmontenegro force-pushed the 16.0-38394-pam-2 branch 6 times, most recently from 1cb5b8a to 51a938e Compare October 29, 2024 15:03
zaoral
zaoral reviewed Oct 29, 2024
View reviewed changes
Copy link
Contributor

@zaoral zaoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only apply IMPORTANT key
The other ones can be applied after merge, not to urgent

l10n_ar_account_tax_settlement_mendoza/models/account_journal.py Outdated Show resolved Hide resolved
l10n_ar_account_tax_settlement_mendoza/models/account_journal.py Outdated Show resolved Hide resolved
l10n_ar_account_tax_settlement_mendoza/models/account_journal.py Outdated Show resolved Hide resolved
l10n_ar_account_tax_settlement_mendoza/models/account_move.py Outdated Show resolved Hide resolved
l10n_ar_account_tax_settlement_mendoza/models/account_payment.py Show resolved Hide resolved
l10n_ar_account_tax_settlement_mendoza/models/res_company.py Outdated Show resolved Hide resolved
l10n_ar_account_tax_settlement_mendoza/wizards/res_config_settings.py Outdated Show resolved Hide resolved
l10n_ar_account_tax_settlement_mendoza/wizard/res_config_settings.py Outdated Show resolved Hide resolved
l10n_ar_account_tax_settlement/models/account_journal.py Show resolved Hide resolved
l10n_ar_account_tax_settlement_mendoza/models/account_tax.py Outdated Show resolved Hide resolved
zaoral
zaoral reviewed Oct 29, 2024
View reviewed changes
l10n_ar_account_tax_settlement_mendoza/__manifest__.py
@@ -0,0 +1,19 @@
{
'name': 'Tax settlement Mendoza',
'version': "16.0.1.0.0",
Copy link
Contributor

@zaoral zaoral Oct 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agregar readme explicandoque hace el modulo.porque esta por seprado, caso especial, que se sube a un aplicativo distinto, y los pasos a configurar posterior a instalar (importar archivo afip activity, archivo riesgo fiscal)

@pablohmontenegro pablohmontenegro changed the title [REF] l10n_ar_account_tax_settlement: sircar refactor para poder cump… [REF] l10n_ar_account_tax_settlement_mendoza: sircar refactor para poder cump… Oct 29, 2024
@pablohmontenegro pablohmontenegro force-pushed the 16.0-38394-pam-2 branch 3 times, most recently from 70f25cb to dc2f264 Compare October 29, 2024 19:10
@pablohmontenegro pablohmontenegro changed the title [REF] l10n_ar_account_tax_settlement_mendoza: sircar refactor para poder cump… [IMP] l10n_ar_account_tax_settlement_mendoza: new module for mendoza AR withholdings Oct 29, 2024
@roboadhoc roboadhoc mentioned this pull request Oct 29, 2024
Closed
@zaoral
Copy link
Contributor

zaoral commented Oct 29, 2024

@roboadhoc r+

roboadhoc pushed a commit to ingadhoc/odoo-argentina that referenced this pull request Oct 29, 2024
@pablohmontenegro
[IMP] l10n_ar_account_withholding: get_partner_alicuot method (accoun…
3174349 
…t.tax)

Task: 38394
In new module l10n_ar_account_tax_settlement_mendoza is extended the method get_partner_alicuot (account.tax) and it is needed to add line=None argument to that method

closes #940

Related: ingadhoc/odoo-argentina-ee#445
Signed-off-by: Katherine Zaoral <kz@adhoc.com.ar>
roboadhoc pushed a commit that referenced this pull request Oct 29, 2024
@pablohmontenegro
[IMP] l10n_ar_account_tax_settlement_mendoza: new module for mendoza …
84ea4e3 
…AR withholdings

closes #445

Tarea: 38394
Related: ingadhoc/odoo-argentina#940
Signed-off-by: Katherine Zaoral <kz@adhoc.com.ar>
@roboadhoc roboadhoc closed this Oct 29, 2024
@fw-bot-adhoc fw-bot-adhoc mentioned this pull request Oct 29, 2024
Closed
@zaoral zaoral deleted the 16.0-38394-pam-2 branch October 29, 2024 20:49
@fw-bot-adhoc
Copy link
Contributor

@pablohmontenegro @zaoral this pull request has forward-port PRs awaiting action (not merged or closed):

10 similar comments
@fw-bot-adhoc
Copy link
Contributor

@pablohmontenegro @zaoral this pull request has forward-port PRs awaiting action (not merged or closed):

@fw-bot-adhoc
Copy link
Contributor

@pablohmontenegro @zaoral this pull request has forward-port PRs awaiting action (not merged or closed):

@fw-bot-adhoc
Copy link
Contributor

@pablohmontenegro @zaoral this pull request has forward-port PRs awaiting action (not merged or closed):

@fw-bot-adhoc
Copy link
Contributor

@pablohmontenegro @zaoral this pull request has forward-port PRs awaiting action (not merged or closed):

@fw-bot-adhoc
Copy link
Contributor

@pablohmontenegro @zaoral this pull request has forward-port PRs awaiting action (not merged or closed):

@fw-bot-adhoc
Copy link
Contributor

@pablohmontenegro @zaoral this pull request has forward-port PRs awaiting action (not merged or closed):

@fw-bot-adhoc
Copy link
Contributor

@pablohmontenegro @zaoral this pull request has forward-port PRs awaiting action (not merged or closed):

@fw-bot-adhoc
Copy link
Contributor

@pablohmontenegro @zaoral this pull request has forward-port PRs awaiting action (not merged or closed):

@fw-bot-adhoc
Copy link
Contributor

@pablohmontenegro @zaoral this pull request has forward-port PRs awaiting action (not merged or closed):

@fw-bot-adhoc
Copy link
Contributor

@pablohmontenegro @zaoral this pull request has forward-port PRs awaiting action (not merged or closed):

@fw-bot-adhoc fw-bot-adhoc mentioned this pull request Jan 22, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zaoral zaoral zaoral requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pablohmontenegro @roboadhoc @zaoral @fw-bot-adhoc