feat: Login Page and Link contact CTA buttons to onboarding tasks on GitHub#28
feat: Login Page and Link contact CTA buttons to onboarding tasks on GitHub#28KKabilan07 wants to merge 4 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
This pull request introduces a dedicated login page and refactors the contact flow to link directly to the GitHub onboarding repository. The changes centralize authentication UI into a single LoginPage component, replacing the previous modal-based approach, and update CTAs to guide new users to complete onboarding tasks.
Changes:
- Created a new LoginPage component with GitHub OAuth authentication and Discord community link
- Updated Contact page CTAs ("Join Our Community" and "Let's Talk") to link directly to the GitHub onboarding repository
- Removed JoinUsModal component and cleaned up associated state and imports
- Modified Navbar to navigate to /login route instead of triggering OAuth directly
- Updated development dependencies: eslint to 10.0.1 and
@types/react-pdfto 5.0.7
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/pages/LoginPage.tsx | New dedicated login page with GitHub OAuth authentication, Discord link, and community values display |
| src/pages/Contact.tsx | Converted modal-triggering buttons to direct GitHub links; removed JoinUsModal state and import |
| src/components/Navbar.tsx | Changed login buttons to navigate to /login route instead of direct OAuth trigger |
| src/components/JoinUsModal.tsx | Deleted modal component (replaced by LoginPage) |
| src/App.tsx | Added /login route mapping to LoginPage component |
| package.json | Updated eslint to 10.0.1 and @types/react-pdf to 5.0.7 |
| package-lock.json | Lock file updates for dependency version changes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| {/* Secondary Action: Discord Join */} | ||
| <a | ||
| href="https://discord.com/invite/Gx8sdGJkU" |
There was a problem hiding this comment.
Inconsistent Discord invite URL format. The codebase uses discord.gg/Gx8sdGJkU in other places (Footer.tsx:18, AboutWhatWeDO.tsx:234, Graph/GitGraph.tsx:151), but this uses discord.com/invite/Gx8sdGJkU. While both formats work, consistency improves maintainability. Consider using discord.gg/Gx8sdGJkU to match the rest of the codebase.
| href="https://discord.com/invite/Gx8sdGJkU" | |
| href="https://discord.gg/Gx8sdGJkU" |
| if (error) throw error; | ||
| } catch (error: any) { | ||
| console.error('Login error:', error.message); | ||
| alert('Failed to login with GitHub. Please try again.'); |
There was a problem hiding this comment.
Using alert() for error messages is inconsistent with the rest of the codebase. Other pages like Graveyard.tsx:66 and IdeaWall.tsx:61 store errors in state and display them in the UI. Consider using a similar pattern here: add an error state variable and display the error message inline in the component instead of using a browser alert dialog. This provides a better user experience and is more consistent with the application's error handling patterns.
Created a new Login Page.
Link contact page buttons to onboarding tasks