Feature/clear command #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codespool
reviewed
Nov 1, 2023
|
Thanks for the feedback, Codespool. The PR has been updated based on your comments. |
ipapandinas
requested changes
Feb 15, 2024
There was a problem hiding this comment.
sorry for the late response @Juminstock, your implementation of the clear command looks pretty solid, thank you for contributing!
I added some comments for small code structure adjustments; once implemented I will approve this PR
|
Hi @ipapandinas, thank you for your comments in the code. I've resolved the bugs and improve the code based on your tips! |
ipapandinas
approved these changes
Feb 26, 2024
There was a problem hiding this comment.
LGTM, thank you for your contribution @Juminstock 🙌
It will be include in the upcoming new release completing the ink-devhub-1 proposal.
Closed
Closed
4 tasks
ipapandinas
force-pushed
the
feature/clearCommand
branch
from
f28c2ed
to
2f6a18e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added clear command and documentation.