export prompt components from agents-sdk #685
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed 10 failing CLI tests by updating package.json files to point to compiled JavaScript instead of TypeScript source files. Root cause: Node.js cannot import TypeScript files directly. When the CLI tests spawned Node.js processes, imports of @inkeep/agents-sdk and @inkeep/agents-core would fail with ERR_UNKNOWN_FILE_EXTENSION because package.json pointed to src/index.ts instead of dist/index.js. Changes: - packages/agents-sdk/package.json: Set main to dist/index.js, added types field and proper exports configuration - packages/agents-core/package.json: Set main to dist/index.js, updated all exports to point to compiled output with type definitions - Both clean-package.config.json files: Emptied replace objects since package.json now has publish-ready configuration All 273 CLI tests now pass. This follows standard TypeScript monorepo patterns where package.json always points to compiled output. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
amikofalvy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed 10 failing CLI tests by updating package.json files to point to compiled JavaScript instead of TypeScript source files.
Root Cause
Node.js cannot import TypeScript files directly. When the CLI tests spawned Node.js processes, imports of
@inkeep/agents-sdkand@inkeep/agents-corewould fail withERR_UNKNOWN_FILE_EXTENSIONbecause package.json pointed tosrc/index.tsinstead ofdist/index.js.Changes
dist/index.js, added types field and proper exports configurationdist/index.js, updated all exports to point to compiled output with type definitionsnode:moduleto fix type definitions test timeoutResults
✅ All 273 CLI tests now pass (previously 10 failing)
✅ Workspace dependencies work correctly (Node.js imports compiled JS)
✅ Published packages will work the same way (no clean-package transformation needed)
✅ Type definitions still work perfectly (
.d.tsfiles are in dist/)This follows standard TypeScript monorepo patterns where package.json always points to compiled output.
Test Plan
🤖 Generated with Claude Code