Make request token and installation ID optional fields for Onboarding…

…, Login and Payment APIs
inloco · Jan 29, 2025 · 937cb6d · 937cb6d
1 parent 3b2ba57
commit 937cb6d
Showing 2 changed files with 20 additions and 85 deletions.
diff --git a/src/main/java/com/incognia/api/IncogniaAPI.java b/src/main/java/com/incognia/api/IncogniaAPI.java
@@ -134,9 +134,6 @@ public static IncogniaAPI instance() {
    */
   public SignupAssessment registerSignup(RegisterSignupRequest request) throws IncogniaException {
     Asserts.assertNotNull(request, "register signup request");
-    Asserts.assertNotEmpty(
-        Optional.ofNullable(request.getRequestToken()).orElse(request.getInstallationId()),
-        "request token");
     Optional<Address> address = Optional.ofNullable(request.getAddress());
     PostSignupRequestBody postSignupRequestBody =
         PostSignupRequestBody.builder()
@@ -187,9 +184,6 @@ public SignupAssessment registerSignup(RegisterSignupRequest request) throws Inc
   public TransactionAssessment registerLogin(RegisterLoginRequest request)
       throws IncogniaException {
     Asserts.assertNotNull(request, "register login request");
-    Asserts.assertNotEmpty(
-        Optional.ofNullable(request.getRequestToken()).orElse(request.getInstallationId()),
-        "request token");
     Asserts.assertNotEmpty(request.getAccountId(), "account id");
     PostTransactionRequestBody requestBody =
         PostTransactionRequestBody.builder()
@@ -382,9 +376,6 @@ public SignupAssessment registerWebSignup(RegisterWebSignupRequest request)
   public TransactionAssessment registerPayment(RegisterPaymentRequest request)
       throws IncogniaException {
     Asserts.assertNotNull(request, "register payment request");
-    Asserts.assertNotEmpty(
-        Optional.ofNullable(request.getRequestToken()).orElse(request.getInstallationId()),
-        "request token");
     Asserts.assertNotEmpty(request.getAccountId(), "account id");
     List<TransactionAddress> transactionAddresses =
         addressMapToTransactionAddresses(request.getAddresses());
@@ -490,4 +481,23 @@ private List<TransactionAddress> addressMapToTransactionAddresses(
             })
         .collect(Collectors.toList());
   }
+
+  public static void main(String[] args) {
+    IncogniaAPI api = IncogniaAPI.init("QBqiqgZrw8bxg4M_k-jjRImqGvzKs2dQ", "x6sC_JIHwxTDXGu3EP3TkKeSU_hlGEa6iZgj-tmifXU-lwVhpGZaAppwoyIqYfME");
+    try {
+      RegisterLoginRequest registerLoginRequest =
+              RegisterLoginRequest.builder()
+                      .accountId("account-id")
+//                      .requestToken("l8dfTwNiUBsdtmMSBvX5sejOnhBmTPSjQC4njDYNrvsuS7c9bRVeq1_xMvyf4tlyUhfaV5aYDn58rO6GMFtdOuekbcXoDwBA7eoEvQn0rt7zMNcP-FeTAGgPhGmW_zSNq4ZTPGWNLJvRqmdBTwW2uw")
+//                      .requestToken(null)
+                      .evaluateTransaction(true) // can be omitted as it uses true as the default value
+                      .build();
+      TransactionAssessment assessment = api.registerLogin(registerLoginRequest);
+      System.out.println(assessment.getRiskAssessment());
+    } catch (IncogniaAPIException e) {
+      System.out.println(e.getMessage());
+    } catch (IncogniaException e) {
+      //Something unexpected happened
+    }
+  }
 }
diff --git a/src/test/java/com/incognia/api/IncogniaAPITest.java b/src/test/java/com/incognia/api/IncogniaAPITest.java
@@ -264,34 +264,6 @@ void testRegisterWebSignup_whenDataIsValid() {
     assertThat(webSignupAssessment.getReasons()).containsExactly(expectedReason);
   }
 
-  @Test
-  @DisplayName("should throw illegal argument exception with correct message")
-  @SneakyThrows
-  void testRegisterSignup_whenEmptyRequestToken() {
-    assertThatThrownBy(
-            () ->
-                client.registerSignup(
-                    RegisterSignupRequest.builder()
-                        .requestToken("")
-                        .address(AddressFixture.ADDRESS_ADDRESS_LINE)
-                        .customProperties(null)
-                        .build()))
-        .isInstanceOf(IllegalArgumentException.class)
-        .hasMessage("'request token' cannot be empty");
-  }
-
-  @Test
-  @DisplayName("should throw illegal argument exception with correct message")
-  @SneakyThrows
-  void testRegisterWebSignup_whenEmptyRequestToken() {
-    assertThatThrownBy(
-            () ->
-                client.registerWebSignup(
-                    RegisterWebSignupRequest.builder().requestToken("").build()))
-        .isInstanceOf(IllegalArgumentException.class)
-        .hasMessage("'request token' cannot be empty");
-  }
-
   @ParameterizedTest
   @ValueSource(booleans = {true})
   @NullSource
@@ -589,54 +561,7 @@ void testRegisterFeedback_whenDataIsValid(boolean dryRun) {
             .build(),
         dryRun);
   }
-
-  @Test
-  @DisplayName("should throw illegal argument exception with correct message")
-  @SneakyThrows
-  void testRegisterPayment_whenRequestTokenIsNotValid() {
-    assertThatThrownBy(
-            () ->
-                client.registerPayment(
-                    RegisterPaymentRequest.builder()
-                        .requestToken("")
-                        .accountId("account id")
-                        .build()))
-        .isInstanceOf(IllegalArgumentException.class)
-        .hasMessage("'request token' cannot be empty");
-    assertThatThrownBy(
-            () ->
-                client.registerPayment(
-                    RegisterPaymentRequest.builder()
-                        .requestToken(null)
-                        .accountId("account id")
-                        .build()))
-        .isInstanceOf(IllegalArgumentException.class)
-        .hasMessage("'request token' cannot be empty");
-  }
-
-  @Test
-  @DisplayName("should throw illegal argument exception with correct message")
-  @SneakyThrows
-  void testRegisterLogin_whenRequestTokenIsNotValid() {
-    assertThatThrownBy(
-            () ->
-                client.registerLogin(
-                    RegisterLoginRequest.builder()
-                        .requestToken("")
-                        .accountId("account id")
-                        .build()))
-        .isInstanceOf(IllegalArgumentException.class)
-        .hasMessage("'request token' cannot be empty");
-    assertThatThrownBy(
-            () ->
-                client.registerLogin(
-                    RegisterLoginRequest.builder()
-                        .requestToken(null)
-                        .accountId("account id")
-                        .build()))
-        .isInstanceOf(IllegalArgumentException.class)
-        .hasMessage("'request token' cannot be empty");
-  }
+
 
   @Test
   @DisplayName("should throw illegal argument exception with correct message")