Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove installation id from register web login #184

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Remove installation id from register web login #184

merged 1 commit into from
Nov 17, 2023

Conversation

gabrielpessoa1
Copy link
Contributor

Proposed changes

As seen here for web, the installation id is not part of the request, since the sessionToken already has this data.

Checklist

  • Style check and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@gabrielpessoa1 gabrielpessoa1 self-assigned this Nov 17, 2023
@gabrielpessoa1 gabrielpessoa1 requested a review from a team as a code owner November 17, 2023 14:52
@gabrielpessoa1 gabrielpessoa1 requested a review from ebaf November 17, 2023 14:52
@gabrielpessoa1 gabrielpessoa1 merged commit 3fe4d47 into master Nov 17, 2023
@gabrielpessoa1 gabrielpessoa1 deleted the fix-web-login-request branch October 24, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaabs gaabs gaabs approved these changes

@bcs5 bcs5 bcs5 approved these changes

@racevedoo racevedoo Awaiting requested review from racevedoo

@ebaf ebaf Awaiting requested review from ebaf ebaf is a code owner automatically assigned from inloco/incognia-owners

Assignees

@gabrielpessoa1 gabrielpessoa1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gabrielpessoa1 @gaabs @bcs5