Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support to missing fields on RegisterFeedback #236

Open
wants to merge 1 commit into
base: feat-feedback-event-as-string
Choose a base branch
from

Conversation

figueredo
Copy link
Contributor

@figueredo figueredo commented Jul 18, 2024

Proposed changes

Adds support to specifying request_token and expires_at when registering a feedback.

Checklist

  • Style check and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@figueredo figueredo requested a review from racevedoo July 18, 2024 20:05
@figueredo figueredo self-assigned this Jul 18, 2024
@figueredo figueredo requested a review from a team as a code owner July 18, 2024 20:05
@figueredo figueredo requested review from gaabs and removed request for a team July 18, 2024 20:05
@figueredo figueredo force-pushed the feat-feedback-event-as-string branch from 65649b8 to 416299d Compare July 19, 2024 20:05
@figueredo figueredo changed the title feat: add support to expires_at on RegisterFeedback feat: add support to missing fields on RegisterFeedback Jul 19, 2024
@figueredo figueredo force-pushed the feat-feedback-expires-at branch 2 times, most recently from 73e6c75 to 44ddd16 Compare July 20, 2024 04:21
@figueredo figueredo force-pushed the feat-feedback-event-as-string branch 2 times, most recently from 977a2ba to 38f2459 Compare July 24, 2024 18:37
Adds support to expires_at and request_token.
@figueredo figueredo force-pushed the feat-feedback-expires-at branch from 44ddd16 to e539a0d Compare July 24, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants