Add metrics from Tinkoff libvirt exporter #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution @Dmitry-Eremeev
Thank you |
Knalltuete5000
requested changes
Jan 24, 2025
|
|
||
| // https://libvirt.org/html/libvirt-libvirt-domain.html#virConnectGetAllDomainStats | ||
| if domainsBlockStats, err = l.ConnectGetAllDomainStats(domains, uint32(libvirt.DomainStatsBlock), 0); err != nil { | ||
| _ = level.Warn(logger).Log("warn", "failed to get additional block stats", "domain", domain.libvirtDomain.Name, "msg", err) |
There was a problem hiding this comment.
Change to the new std logging system
| statsIndex := "0" | ||
| var capacity, flushRequests, flushTimes, readTime, writeTime uint64 | ||
| var prometheusDiskLabels []string | ||
| StatName := regexp.MustCompile(`block\.(\d+)\.(.+)`) |
There was a problem hiding this comment.
Is it possible to extract the regex in a static variable so the regex is not compiled on every function call
Added metrics from archived Tinkoff exporter: libvirt_domain_block_stats_read_time_seconds_total libvirt_domain_block_stats_write_time_seconds_total libvirt_domain_block_stats_flush_requests_total libvirt_domain_block_stats_flush_time_seconds_total libvirt_domain_block_stats_capacity_bytes libvirt_domain_memory_stats_used_percent libvirt_domain_memory_stats_actual_balloon_bytes libvirt_domain_memory_stats_major_fault_total libvirt_domain_memory_stats_minor_fault_total inovex#22
Dmitry-Eremeev
force-pushed
the
issues/22
branch
from
d1078b3 to
f5fab14
Compare
done
it's already there
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added metrics from archived Tinkoff exporter:
libvirt_domain_block_stats_read_time_seconds_total
libvirt_domain_block_stats_write_time_seconds_total
libvirt_domain_block_stats_flush_requests_total
libvirt_domain_block_stats_flush_time_seconds_total
libvirt_domain_block_stats_capacity_bytes
libvirt_domain_memory_stats_used_percent
libvirt_domain_memory_stats_actual_balloon_bytes
libvirt_domain_memory_stats_major_fault_total
libvirt_domain_memory_stats_minor_fault_total
#22